Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752881AbbLHV20 (ORCPT ); Tue, 8 Dec 2015 16:28:26 -0500 Received: from www.linutronix.de ([62.245.132.108]:52410 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751017AbbLHV2Z (ORCPT ); Tue, 8 Dec 2015 16:28:25 -0500 Date: Tue, 8 Dec 2015 22:27:31 +0100 (CET) From: Thomas Gleixner To: Boris Ostrovsky cc: David Vrabel , x86@kernel.org, linux-kernel@vger.kernel.org, Vitaly Kuznetsov , Ingo Molnar , "H. Peter Anvin" , xen-devel@lists.xenproject.org Subject: Re: [Xen-devel] [PATCHv1] x86: rtc_cmos platform device requires legacy irqs In-Reply-To: <5667487F.6040307@oracle.com> Message-ID: References: <1449139404-25101-1-git-send-email-david.vrabel@citrix.com> <56619DCE.3050900@citrix.com> <5661B033.10503@citrix.com> <5667487F.6040307@oracle.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1113 Lines: 38 On Tue, 8 Dec 2015, Boris Ostrovsky wrote: > On 12/08/2015 04:02 PM, Thomas Gleixner wrote: > > > > --- a/arch/x86/kernel/rtc.c > > > > +++ b/arch/x86/kernel/rtc.c > > > > @@ -200,6 +200,9 @@ static __init int add_rtc_cmos(void) > > > > } > > > > #endif > > > > + if (xen_pv_domain()) > > > > + return -ENODEV; > > > > + > > > Note there's a missing include that breaks !XEN builds. > > What's the state of this? > > I think we are waiting for x86 maintainers to express their preference. There > were 3 proposals to add in add_rtc_cmos() > > 1. if (!nr_legacy_irqs()) > return -ENODEV; > > 2. #ifdef XEN > if (xen_pv_domain()) > return -ENODEV; > #endif > > 3. if (paravirt_enabled()) > return -ENODEV; Either #2 (but with the #ifdefs removed, include the proper header instead) or #3. Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/