Subject: Re: [PATCH] soc: TI knav_qmss: fix dma_addr_t printing
To: Arnd Bergmann <arnd@arndb.de>, linux-arm-kernel@lists.infradead.org
References: <2560281.KhcNzi0XgD@wuerfel> <56670B21.5060209@oracle.com>
 <18371096.H4qt47cWYH@wuerfel>
Cc: Murali Karicheri <m-karicheri2@ti.com>, "Kwok, WingMan" <w-kwok2@ti.com>,
        linux-kernel@vger.kernel.org, Santosh Shilimkar <ssantosh@kernel.org>
From: santosh shilimkar <santosh.shilimkar@oracle.com>
Organization: Oracle Corporation
Message-ID: <56675981.5060206@oracle.com>
Date: Tue, 8 Dec 2015 14:28:17 -0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.4.0
MIME-Version: 1.0
In-Reply-To: <18371096.H4qt47cWYH@wuerfel>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1106
Lines: 27

On 12/8/2015 1:34 PM, Arnd Bergmann wrote:
> On Tuesday 08 December 2015 08:53:53 santosh shilimkar wrote:
>> On 12/8/2015 7:30 AM, Arnd Bergmann wrote:
>>> The knav_qmss driver is currently broken when CONFIG_LPAE is
>>> set, which is a bit surprising because I'd expect that any serious
>>> users of this platforms would have more than 2GB of RAM and require
>>> LPAE.
>>>
>> Well it has been working with LPAE enable always. The production
>> systems do but IIRC, some of the Eval board were still build with
>> just 2 GB memory.
>
> Maybe that just means that the debug code is never used and we can remove
> all the dev_dbg instead? That might actually be nicer as it would reduce
> the amount of code in your driver (slightly).
>
It was added in intention so that it is useful. I agree if it is not
used or useful, we should remove it.

Regards,
Santosh

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/