Date: Tue, 8 Dec 2015 15:30:16 -0800
From: Jacob Pan <jacob.jun.pan@linux.intel.com>
To: Prarit Bhargava <prarit@redhat.com>
Cc: linux-kernel@vger.kernel.org,
        "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
        Radivoje Jovanovic <radivoje.jovanovic@intel.com>,
        Seiichi Ikarashi <s.ikarashi@jp.fujitsu.com>,
        Mathias Krause <minipli@googlemail.com>,
        Ajay Thomas <ajay.thomas.david.rajamanickam@intel.com>,
        jacob.jun.pan@linux.intel.com
Subject: Re: [PATCH] powercap, intel_rapl.c, fix BIOS lock check
Message-ID: <20151208153016.0dcebee1@icelake>
In-Reply-To: <1449599602-4512-1-git-send-email-prarit@redhat.com>
References: <1449599602-4512-1-git-send-email-prarit@redhat.com>
Organization: OTC
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 843
Lines: 21

On Tue,  8 Dec 2015 13:33:22 -0500
Prarit Bhargava <prarit@redhat.com> wrote:

> Intel RAPL initialized on several systems where the BIOS lock bit (msr
> 0x610, bit 63) was set.  This occured because the return value of
> rapl_read_data_raw() was being checked, rather than the value of the
> variable passed in, locked.
> 
> This patch properly implments the rapl_read_data_raw() call to check
> the variable locked, and now the Intel RAPL driver outputs the
> warning:
> 
> 	intel_rapl: RAPL package 0 domain package locked by BIOS
> 
> and does not initialize for the package.
Looks good to me.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/