Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752811AbbLIBGp (ORCPT ); Tue, 8 Dec 2015 20:06:45 -0500 Received: from victor.provo.novell.com ([137.65.250.26]:43981 "EHLO prv3-mh.provo.novell.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751960AbbLIBGn (ORCPT ); Tue, 8 Dec 2015 20:06:43 -0500 From: NeilBrown To: Peter Zijlstra , torvalds@linux-foundation.org, tglx@linutronix.de, linux-kernel@vger.kernel.org, efault@gmx.de, mingo@kernel.org, hpa@zytor.com, vladimir.murzin@arm.com Date: Wed, 09 Dec 2015 12:06:33 +1100 Cc: linux-tip-commits@vger.kernel.org, jstancek@redhat.com, Oleg Nesterov Subject: Re: [tip:locking/core] sched/wait: Fix signal handling in bit wait helpers In-Reply-To: <20151208104712.GJ6356@twins.programming.kicks-ass.net> References: <20151201130404.GL3816@twins.programming.kicks-ass.net> <20151208104712.GJ6356@twins.programming.kicks-ass.net> User-Agent: Notmuch/0.20.2 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-suse-linux-gnu) Message-ID: <87zixkph0m.fsf@notabene.neil.brown.name> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1830 Lines: 59 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Tue, Dec 08 2015, Peter Zijlstra wrote: >>=20=20 > > *sigh*, so that patch was broken.. the below might fix it, but please > someone look at it, I seem to have a less than stellar track record > here... This new change seems to be more intrusive than should be needed. Can't we just do: __sched int bit_wait(struct wait_bit_key *word) { + long state =3D current->state; =2D if (signal_pending_state(current->state, current)) =2D return 1; schedule(); + if (signal_pending_state(state, current)) + return -EINTR; return 0; } ?? (and sorry for breaking this in the first place!) NeilBrown --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJWZ36ZAAoJEDnsnt1WYoG5BOIP/1N4Fa2wcQSeNlugkFBZQtK8 Acn3L+IN+T6qitfHcijdLh36pAym5LYKxf8XenUtcCOn163ZYn/PcvWbONk7b7uU ogknHFZ7lgXRXmmhcmnD1PlB1vwxd+00DDXTNZ5UpAlIK1aHQ5vchaFcwk71leIL 76xBBP0RTeKIB14zXWQ7LE1QztsN+a69v2mWoop6lxGzEqaZAk72kcIuh+LUHI/Y rYrhzNawtJM/w36n86jCfrXSt9OvKNBIy4oL1H7yw6f679VkST0iqOVFPJFhN3HD 4OIy6wwYTyZrc5EVsOmbu2lEVNZXVWdonEUFXY4+odNhbG/I5e3b8b6wyuBmhKI9 iirzjYLH0fHEmhL6yIehDyTgDHaYW5dPKYNlCFOqgYFz8RaY9JvfiR2rljpljfGS bdsRIIXVFlaM04spBAIWDWIFM/NnyY+9scVAOWhhqohxRVLiRkXzfJqqDmKPC1Ga Gt3UAu3zWIWCLPUinUtfOenSbgeG/eZvcH0jm+kQTn9f0J0CnzZN+NHEG3pdGQ4M GHzaEZfq94ulv0yPpaJ3Gtnf+IZHMUQEfJFzhYuyO9poEBYt//oTLXvfYKYxPb/V kUNcq+fND2LyxnmPzQeYDpWEEm4LloPKV/ITFW2WYS7MhhKPBRiyBhkEDUgl1LgV DM3ztsudSv/DaBkIpmGu =pDmz -----END PGP SIGNATURE----- --=-=-=-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/