Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752971AbbLICRU (ORCPT ); Tue, 8 Dec 2015 21:17:20 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:47863 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752104AbbLICRS (ORCPT ); Tue, 8 Dec 2015 21:17:18 -0500 Date: Tue, 08 Dec 2015 21:17:15 -0500 (EST) Message-Id: <20151208.211715.790899872740551674.davem@davemloft.net> To: scottwood@freescale.com Cc: afleming@gmail.com, igal.liberman@freescale.com, netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, madalin.bucur@freescale.com, pebolle@tiscali.nl, joakim.tjernlund@transmode.se, ppc@mindchasers.com, stephen@networkplumber.org Subject: Re: [v9, 6/6] fsl/fman: Add FMan MAC driver From: David Miller In-Reply-To: <1449614678.15946.152.camel@freescale.com> References: <1449127157-9400-7-git-send-email-igal.liberman@freescale.com> <1449614678.15946.152.camel@freescale.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 08 Dec 2015 18:17:18 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1281 Lines: 34 From: Scott Wood Date: Tue, 8 Dec 2015 16:44:38 -0600 > On Tue, 2015-12-08 at 14:18 -0600, Andy Fleming wrote: >> On Thu, Dec 3, 2015 at 1:19 AM, wrote: >> > From: Igal Liberman >> > >> > This patch adds the Ethernet MAC driver supporting the three >> > different types of MACs: dTSEC, tGEC and mEMAC. >> > >> > Signed-off-by: Igal Liberman >> >> [...] >> >> > + >> > +MODULE_LICENSE("Dual BSD/GPL"); >> > + >> > +MODULE_AUTHOR("Emil Medve "); >> >> I imagine this email address doesn't exist anymore, or won't soon. >> This is also an issue in the ethernet driver (with my old address). >> I'm not sure what the right approach is, but we shouldn't be putting >> obsolete email addresses in the kernel. > > I don't think a MODULE_AUTHOR tag makes sense for drivers like this that had a > lot of people work on them. git history is better for giving credit in such > cases. Agreed. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/