Message-ID: <5667A073.60309@cmss.chinamobile.com>
Date: Wed, 09 Dec 2015 11:30:59 +0800
From: Xiubo Li <lixiubo@cmss.chinamobile.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0
MIME-Version: 1.0
To: Mark Brown <broonie@kernel.org>
CC: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] regmap: cache: Tidy up the code to suppress stylecheck
 warnings
References: <1449135113-31892-1-git-send-email-lixiubo@cmss.chinamobile.com> <1449135113-31892-2-git-send-email-lixiubo@cmss.chinamobile.com> <20151208171235.GV5727@sirena.org.uk>
In-Reply-To: <20151208171235.GV5727@sirena.org.uk>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1017
Lines: 38


On 09/12/2015 01:12, Mark Brown wrote:
> On Thu, Dec 03, 2015 at 05:31:51PM +0800, Xiubo Li wrote:
>
>> There will be some warning like the following when checking new
>> patches near this code:
>>      "WARNING: Missing a blank line after declarations"
>> This patch will suppress this warning.
>>   	switch (map->cache_word_size) {
>> -	case 1: {
>> -		u8 *cache = base;
>> -		cache[idx] = val;
>> +	case 1:
>> +		((u8 *)base)[idx] = val;
>>   		break;
>> -	}
> If there's a change to shut checkpatch up I'd rather just add the blank
> line it's asking for - the code is the way it is currently to avoid the
> casts since they're hard for people to read.
Both of them are okay for me.

I will send the v2 for these just adding one blank line.

Thanks,

BRs

Xiubo


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/