Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752293AbbLIFTP (ORCPT ); Wed, 9 Dec 2015 00:19:15 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44403 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751415AbbLIFTO (ORCPT ); Wed, 9 Dec 2015 00:19:14 -0500 Date: Wed, 9 Dec 2015 13:21:21 +0800 From: Minfei Huang To: Minfei Huang Cc: axboe@fb.com, m@bjorling.me, akinobu.mita@gmail.com, rusty@rustcorp.com.au, keith.busch@intel.com, mcgrof@suse.com, krinkin.m.u@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] null_blk: Remove null block from list in error path Message-ID: <20151209052121.GB23900@dhcp-128-25.nay.redhat.com> References: <1448630773-4119-1-git-send-email-mnfhuang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1448630773-4119-1-git-send-email-mnfhuang@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1584 Lines: 53 Ping. Any comment is appreciate. Thanks Minfei On 11/27/15 at 09:26pm, Minfei Huang wrote: > To make consistent of null block list, we should remove enqueued null > block from the list before freeing it. > > Signed-off-by: Minfei Huang > --- > drivers/block/null_blk.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/block/null_blk.c b/drivers/block/null_blk.c > index ec99568..729ecd7 100644 > --- a/drivers/block/null_blk.c > +++ b/drivers/block/null_blk.c > @@ -738,7 +738,7 @@ static int null_add_dev(void) > rv = nvm_register(nullb->q, nullb->disk_name, > &null_lnvm_dev_ops); > if (rv) > - goto out_cleanup_blk_queue; > + goto out_cleanup_blk_list; > goto done; > } > > @@ -765,6 +765,10 @@ done: > out_cleanup_lightnvm: > if (use_lightnvm) > nvm_unregister(nullb->disk_name); > +out_cleanup_blk_list: > + mutex_lock(&lock); > + list_del_init(&nullb->list); > + mutex_unlock(&lock); > out_cleanup_blk_queue: > blk_cleanup_queue(nullb->q); > out_cleanup_tags: > -- > 1.8.3.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/