Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752222AbbLIHkk (ORCPT ); Wed, 9 Dec 2015 02:40:40 -0500 Received: from casper.infradead.org ([85.118.1.10]:39462 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751358AbbLIHki (ORCPT ); Wed, 9 Dec 2015 02:40:38 -0500 Date: Wed, 9 Dec 2015 08:40:33 +0100 From: Peter Zijlstra To: NeilBrown Cc: torvalds@linux-foundation.org, tglx@linutronix.de, linux-kernel@vger.kernel.org, efault@gmx.de, mingo@kernel.org, hpa@zytor.com, vladimir.murzin@arm.com, linux-tip-commits@vger.kernel.org, jstancek@redhat.com, Oleg Nesterov Subject: Re: [tip:locking/core] sched/wait: Fix signal handling in bit wait helpers Message-ID: <20151209074033.GF6357@twins.programming.kicks-ass.net> References: <20151201130404.GL3816@twins.programming.kicks-ass.net> <20151208104712.GJ6356@twins.programming.kicks-ass.net> <87zixkph0m.fsf@notabene.neil.brown.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87zixkph0m.fsf@notabene.neil.brown.name> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 764 Lines: 23 On Wed, Dec 09, 2015 at 12:06:33PM +1100, NeilBrown wrote: > On Tue, Dec 08 2015, Peter Zijlstra wrote: > > >> > > > > *sigh*, so that patch was broken.. the below might fix it, but please > > someone look at it, I seem to have a less than stellar track record > > here... > > This new change seems to be more intrusive than should be needed. > Can't we just do: > > > __sched int bit_wait(struct wait_bit_key *word) > { > + long state = current->state; No, current->state can already be changed by this time. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/