Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752290AbbLIIC7 (ORCPT ); Wed, 9 Dec 2015 03:02:59 -0500 Received: from mail-db3on0102.outbound.protection.outlook.com ([157.55.234.102]:57260 "EHLO emea01-db3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751358AbbLIIC5 convert rfc822-to-8bit (ORCPT ); Wed, 9 Dec 2015 03:02:57 -0500 From: "Pathak, Rahul (R.)" To: Alan Stern CC: "gregkh@linuxfoundation.org" , "kborer@gmail.com" , "dan.carpenter@oracle.com" , "chasemetzger15@gmail.com" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2] usb: Use memdup_user to reuse the code Thread-Topic: [PATCH v2] usb: Use memdup_user to reuse the code Thread-Index: AQHRMbNUIeAYKt1FS06zPSs0/3kOQJ7BNUaAgAEVwBo= Date: Wed, 9 Dec 2015 08:02:53 +0000 Message-ID: References: <20151208122358.GA17073@visteon.com>, In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=rpathak@visteon.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [132.245.226.69] x-microsoft-exchange-diagnostics: 1;DB4PR06MB587;5:QJf1fYOA6466Bxp2j5oNr84jY8UrodG6gpBPUuA2snDoqUuuF+YGG4Sp1UEfIZM7ArQUVRESXr3K7SWgCvRipaw4yy9YQX6ADpleEvz9ytrD5e/tK3Hww62tbQk8Q96SU0o4WQYWcGLz/MeOBeNRZA==;24:2YAAs8D8VJg0+Ud2FH9U+I83GlPxdGApjD/E6ulnb3gf+uoaU4hIESy+PCNfa5Shx8MUtpKdK/nBpGz2k2vNN2lghK0z1LdijwhUpb260rM= x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB4PR06MB587; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(208512329853888)(35762410373642)(146099531331640); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(2401047)(520078)(5005006)(8121501046)(3002001)(10201501046);SRVR:DB4PR06MB587;BCL:0;PCL:0;RULEID:;SRVR:DB4PR06MB587; x-forefront-prvs: 0785459C39 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(189002)(54534003)(199003)(24454002)(377454003)(86362001)(76176999)(54356999)(74316001)(19580405001)(122556002)(10400500002)(5002640100001)(19580395003)(106356001)(50986999)(101416001)(76576001)(189998001)(586003)(81156007)(2171001)(5003600100002)(40100003)(87936001)(1096002)(97736004)(106116001)(5004730100002)(77096005)(110136002)(66066001)(2950100001)(5001960100002)(92566002)(1220700001)(102836003)(5008740100001)(33656002)(2900100001)(105586002)(6116002)(11100500001)(3846002);DIR:OUT;SFP:1102;SCL:1;SRVR:DB4PR06MB587;H:DB4PR06MB585.eurprd06.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT MIME-Version: 1.0 X-OriginatorOrg: visteon.com X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Dec 2015 08:02:53.3039 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 7a147aaf-01ec-498c-80a1-e34a8c63c548 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR06MB587 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2521 Lines: 67 Hello Alan, Should I resend this patch version with the tear line correction? Regards Rahul Pathak ________________________________________ From: Alan Stern Sent: Tuesday, December 8, 2015 8:53 PM To: Pathak, Rahul (R.) Cc: gregkh@linuxfoundation.org; kborer@gmail.com; dan.carpenter@oracle.com; chasemetzger15@gmail.com; linux-usb@vger.kernel.org; linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] usb: Use memdup_user to reuse the code On Tue, 8 Dec 2015, Pathak, Rahul (R.) wrote: > From: Rahul Pathak > > Fixing coccicheck warning which recommends to use memdup_user instead > to reimplement its code, using memdup_user simplifies the code > > ./drivers/usb/core/devio.c:1398:11-18: WARNING opportunity for memdup_user > > Changes after v1: setting isopkt=NULL for proper kfree() call This line belongs below the "---" tear line, so that it doesn't show up in the final commit changelog. People reading the final commit won't care about earlier versions of the patch. > Signed-off-by: Rahul Pathak > --- > drivers/usb/core/devio.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c > index 38ae877c..844407c 100644 > --- a/drivers/usb/core/devio.c > +++ b/drivers/usb/core/devio.c > @@ -1395,11 +1395,10 @@ static int proc_do_submiturb(struct usb_dev_state *ps, struct usbdevfs_urb *uurb > number_of_packets = uurb->number_of_packets; > isofrmlen = sizeof(struct usbdevfs_iso_packet_desc) * > number_of_packets; > - isopkt = kmalloc(isofrmlen, GFP_KERNEL); > - if (!isopkt) > - return -ENOMEM; > - if (copy_from_user(isopkt, iso_frame_desc, isofrmlen)) { > - ret = -EFAULT; > + isopkt = memdup_user(iso_frame_desc, isofrmlen); > + if (IS_ERR(isopkt)) { > + ret = PTR_ERR(isopkt); > + isopkt = NULL; > goto error; > } > for (totlen = u = 0; u < number_of_packets; u++) { Aside from that, Acked-by: Alan Stern Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/