Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753461AbbLIIuw (ORCPT ); Wed, 9 Dec 2015 03:50:52 -0500 Received: from mail-wm0-f43.google.com ([74.125.82.43]:37923 "EHLO mail-wm0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752271AbbLIIuu (ORCPT ); Wed, 9 Dec 2015 03:50:50 -0500 Date: Wed, 9 Dec 2015 08:50:47 +0000 From: Lee Jones To: Rasmus Villemoes Cc: patches@opensource.wolfsonmicro.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mfd: wm831x: fix broken wm831x_unique_id_show Message-ID: <20151209085047.GA17876@x1> References: <1449358779-19066-1-git-send-email-linux@rasmusvillemoes.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1449358779-19066-1-git-send-email-linux@rasmusvillemoes.dk> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1787 Lines: 55 On Sun, 06 Dec 2015, Rasmus Villemoes wrote: > wm831x_unique_id_show currently displays an interesting pattern of '0' > and '3' characters which isn't very useful (figuring out why is left > as an exercise for the reader). Presumably "buf[i]" should have been > "id[i] & 0xff". > > But while there, it is much simpler to simply use %phN and do all the > formatting at once. > > Signed-off-by: Rasmus Villemoes > --- > drivers/mfd/wm831x-otp.c | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) Applied, thanks. > diff --git a/drivers/mfd/wm831x-otp.c b/drivers/mfd/wm831x-otp.c > index b90f3e06b6c9..ebac0027f8e0 100644 > --- a/drivers/mfd/wm831x-otp.c > +++ b/drivers/mfd/wm831x-otp.c > @@ -47,20 +47,14 @@ static ssize_t wm831x_unique_id_show(struct device *dev, > struct device_attribute *attr, char *buf) > { > struct wm831x *wm831x = dev_get_drvdata(dev); > - int i, rval; > + int rval; > char id[WM831X_UNIQUE_ID_LEN]; > - ssize_t ret = 0; > > rval = wm831x_unique_id_read(wm831x, id); > if (rval < 0) > return 0; > > - for (i = 0; i < WM831X_UNIQUE_ID_LEN; i++) > - ret += sprintf(&buf[ret], "%02x", buf[i]); > - > - ret += sprintf(&buf[ret], "\n"); > - > - return ret; > + return sprintf(buf, "%*phN\n", WM831X_UNIQUE_ID_LEN, id); > } > > static DEVICE_ATTR(unique_id, 0444, wm831x_unique_id_show, NULL); -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/