Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753578AbbLIJho (ORCPT ); Wed, 9 Dec 2015 04:37:44 -0500 Received: from mail-qg0-f41.google.com ([209.85.192.41]:35012 "EHLO mail-qg0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752689AbbLIJhl (ORCPT ); Wed, 9 Dec 2015 04:37:41 -0500 MIME-Version: 1.0 In-Reply-To: <20151209034137.GA15954@rob-hp-laptop> References: <1449578711-6141-1-git-send-email-mcoquelin.stm32@gmail.com> <1449578711-6141-3-git-send-email-mcoquelin.stm32@gmail.com> <20151209034137.GA15954@rob-hp-laptop> Date: Wed, 9 Dec 2015 10:37:40 +0100 Message-ID: Subject: Re: [PATCH v3 2/9] Documentation: dt-bindings: Document STM32 pinctrl driver DT bindings From: Maxime Coquelin To: Rob Herring Cc: Linus Walleij , Mark Rutland , "linux-gpio@vger.kernel.org" , Arnd Bergmann , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , =?UTF-8?Q?Andreas_F=C3=A4rber?= , "devicetree@vger.kernel.org" , Daniel Thompson , Bruno Herrera Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2825 Lines: 66 Hi Rob, 2015-12-09 4:41 GMT+01:00 Rob Herring : > On Tue, Dec 08, 2015 at 01:45:04PM +0100, Maxime Coquelin wrote: >> Signed-off-by: Maxime Coquelin >> --- >> .../bindings/pinctrl/st,stm32-pinctrl.txt | 126 +++++++++++++++++++++ >> 1 file changed, 126 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt >> >> diff --git a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt >> new file mode 100644 >> index 0000000..7b4800c >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt >> @@ -0,0 +1,126 @@ >> +* STM32 GPIO and Pin Mux/Config controller >> + >> +STMicroelectronics's STM32 MCUs intregrate a GPIO and Pin mux/config hardware >> +controller. It controls the input/output settings on the available pins and >> +also provides ability to multiplex and configure the output of various on-chip >> +controllers onto these pads. >> + >> +Pin controller node: >> +Required properies: >> + - compatible: value should be one of the following: >> + (a) "st,stm32f429-pinctrl" >> + - #address-cells: The value of this property must be 1 >> + - #size-cells : The value of this property must be 1 >> + - ranges : defines mapping between pin controller node (parent) to >> + gpio-bank node (children). >> + - pins-are-numbered: Specify the subnodes are using numbered pinmux to >> + specify pins. >> + >> +GPIO controller/bank node: >> +Required properties: >> + - gpio-controller : Indicates this device is a GPIO controller >> + - #gpio-cells : Should be two. >> + The first cell is the pin number >> + The second one is the polarity: >> + - 0 for active high >> + - 1 for active low >> + - reg : The gpio address range, relative to the pinctrl range >> + - clocks : clock that drives this bank >> + - st,bank-name : Should be a name string for this bank as specified in >> + the datasheet > > How do you intend to use this? We should come up with something generic > or drop it. Good point. It is used to have a meaningful name set in gpio_chip's label. I see two alternatives: 1. replace "st,bank-name" with label 2. use aliases, and construct label in driver with something like: kasprintf(GFP_KERNEL, "GPIO%c", 'A' + of_alias_get_id(np, "gpio")); What do you prefer? Do you have other ideas? Thanks, Maxime -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/