From: Arnd Bergmann <arnd@arndb.de>
To: y2038@lists.linaro.org
Cc: Bamvor Jian Zhang <bamvor.zhangjian@linaro.org>,
        linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
        broonie@kernel.org, sudipm.mukherjee@gmail.com
Subject: Re: [Y2038] [PATCH 1/2] ppdev: convert to y2038 safe
Date: Wed, 09 Dec 2015 10:45:39 +0100
Message-ID: <14664570.qCTxRETJS5@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <1449641498-5761-2-git-send-email-bamvor.zhangjian@linaro.org>
References: <1449641498-5761-1-git-send-email-bamvor.zhangjian@linaro.org> <1449641498-5761-2-git-send-email-bamvor.zhangjian@linaro.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1039
Lines: 25

On Wednesday 09 December 2015 14:11:37 Bamvor Jian Zhang wrote:
> The y2038 issue for ppdev is changes of timeval in the ioctl
> (PPSETTIME and PPGETTIME). The size of struct timeval changes from
> 8bytes to 16bytes due to the changes of time_t. It lead to the
> changes of the command of ioctl, e.g. for PPGETTIME, We have:
> 
> on 32-bit (old): 0x80087095
> on 32-bit (new): 0x80107095
> on 64-bit      : 0x80107095
> 
> This patch define these two ioctl commands to support the 32bit
> and 64bit time_t application at the same time. And, introduce
> pp_set_timeout to remove some duplicated code.
> 
> Signed-off-by: Bamvor Jian Zhang <bamvor.zhangjian@linaro.org>

I've reviewed the previous versions in detail, and am happy with
the latest one.

Reviewed-by: Arnd Bergmann <arnd@arndb.de>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/