Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754146AbbLIMYU (ORCPT ); Wed, 9 Dec 2015 07:24:20 -0500 Received: from mail-wm0-f51.google.com ([74.125.82.51]:38810 "EHLO mail-wm0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751521AbbLIMYS (ORCPT ); Wed, 9 Dec 2015 07:24:18 -0500 MIME-Version: 1.0 In-Reply-To: <00b701d13279$d54d9c80$7fe8d580$@samsung.com> References: <1449661081-15435-2-git-send-email-sunil.kovvuri@gmail.com> <00b701d13279$d54d9c80$7fe8d580$@samsung.com> Date: Wed, 9 Dec 2015 17:54:16 +0530 Message-ID: Subject: Re: [PATCH 1/2] net: thunderx: HW TSO support for pass-2 hardware From: Sunil Kovvuri To: Pavel Fedin Cc: Linux Netdev List , LKML , LAKML , Sunil Goutham , Sunil Goutham Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 854 Lines: 26 >> + bool tns_mode:1; >> + bool sqs_mode:1; >These little refactors are creeping in your code without even being mentioned in the commit message, this is not good practice. Okay, will include these in the commit message. >IMHO. Additionally, may be turn these two flags into something like: >enum nicvf_mode { > NICVF_BYPASS, > NICVF_TNS, > NICVF_SQS >}; >? Anyway, these modes are mutually exclusive. VF driver always assumed to be in BYPASS mode. Will submit a seperate cleanup patch to get rid of 'tns_mode' boolean. Thanks, Sunil. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/