Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754272AbbLINVf (ORCPT ); Wed, 9 Dec 2015 08:21:35 -0500 Received: from mga09.intel.com ([134.134.136.24]:23005 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752952AbbLINVa (ORCPT ); Wed, 9 Dec 2015 08:21:30 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,403,1444719600"; d="scan'208";a="615153127" Date: Wed, 9 Dec 2015 15:21:23 +0200 From: Heikki Krogerus To: Noam Camus Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, gregkh@linuxfoundation.org, jslaby@suse.com, peter@hurleysoftware.com, fransklaver@gmail.com, Alexey.Brodkin@synopsys.com, vgupta@synopsys.com Subject: Re: [PATCH-v8] serial: 8250_dw: Add support for big-endian MMIO accesses Message-ID: <20151209132123.GB14285@kuha.fi.intel.com> References: <1444113590-19722-1-git-send-email-noamc@ezchip.com> <1445158908-9610-1-git-send-email-noamc@ezchip.com> <20151209131939.GA14285@kuha.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151209131939.GA14285@kuha.fi.intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 961 Lines: 29 On Wed, Dec 09, 2015 at 03:19:39PM +0200, Heikki Krogerus wrote: > Hi Noam, > > On Sun, Oct 18, 2015 at 12:01:48PM +0300, Noam Camus wrote: > > diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw.c > > index a0cdbf3..880f712 100644 > > --- a/drivers/tty/serial/8250/8250_dw.c > > +++ b/drivers/tty/serial/8250/8250_dw.c > > @@ -63,6 +63,9 @@ struct dw8250_data { > > struct clk *pclk; > > struct reset_control *rst; > > struct uart_8250_dma dma; > > + unsigned int (*serial_in)(void __iomem *addr); > > + void (*serial_out)(unsigned int value, > > + void __iomem *addr); > > This is really ideal .. Meant to say _not_ ideal. Sorry about that. Cheers, -- heikki -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/