Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751219AbbLIOgh (ORCPT ); Wed, 9 Dec 2015 09:36:37 -0500 Received: from mail.kernel.org ([198.145.29.136]:51157 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750748AbbLIOge (ORCPT ); Wed, 9 Dec 2015 09:36:34 -0500 MIME-Version: 1.0 In-Reply-To: <566824AD.4080003@sonymobile.com> References: <1449621618-11900-1-git-send-email-tim.bird@sonymobile.com> <20151209041153.GA29549@rob-hp-laptop> <566824AD.4080003@sonymobile.com> From: Rob Herring Date: Wed, 9 Dec 2015 08:36:11 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 1/3] dt-binding: power: Add otg regulator binding To: Tim Bird Cc: "pawel.moll@arm.com" , "mark.rutland@arm.com" , "ijc+devicetree@hellion.org.uk" , "sre@kernel.org" , "dbaryshkov@gmail.com" , "dwmw2@infradead.org" , "agross@codeaurora.org" , =?UTF-8?Q?Andersson=2C_Bj=C3=B6rn?= , "devicetree@vger.kernel.org" , "linux-pm@vger.kernel.org" , "linux-arm-msm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "tbird20d@gmail.com" , Courtney Cavin Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1940 Lines: 43 On Wed, Dec 9, 2015 at 6:55 AM, Tim Bird wrote: > On 12/08/2015 08:11 PM, Rob Herring wrote: >> On Tue, Dec 08, 2015 at 04:40:16PM -0800, Tim Bird wrote: >>> Add a binding for the regulator which controls the OTG chargepath switch. >>> The OTG switch gets its power from pm8941_5vs1, and that should be >>> expressed as a usb-otg-in-supply property in the DT node for the >>> charger driver. The regulator name is "otg". [...] >>> +child nodes: >>> +- otg: >>> + Usage: optional >>> + Description: This node defines a regulator used to control the direction >>> + of VBUS voltage - specifically: whether to supply voltage >>> + to VBUS for host mode operation of the OTG port, or allow >>> + input voltage from external VBUS for charging. In the >>> + hardware, the supply for this regulator comes from >>> + usb-otg-in-supply. >> >> Doesn't this regulator need to have a name defined? > > I'm not sure what you mean. The regulator name is "otg", defined by the DT node > name. The code requires that the DT node name be "otg", and defines a regulator > with the same name. > > As far as I know, you have to define a DT label for the node, in order > to reference this regulator with a phandle. Is that what you are referring to? > I usually use "chg_otg" as the label. Are you asking that this be reflected > in the example? You need a regulator-name property. Also, should should define valid values for regulator-min-microvolt and regulator-max-microvolt. Thinking about this some more, the node name should be generic, so just "regulator". The label does not need to be generic. Rob -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/