Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751894AbbLIPP4 (ORCPT ); Wed, 9 Dec 2015 10:15:56 -0500 Received: from mail-ob0-f177.google.com ([209.85.214.177]:33332 "EHLO mail-ob0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751407AbbLIPPw (ORCPT ); Wed, 9 Dec 2015 10:15:52 -0500 MIME-Version: 1.0 In-Reply-To: <1448706409-16912-1-git-send-email-sebastian.hesselbarth@gmail.com> References: <1448705645-13881-1-git-send-email-sebastian.hesselbarth@gmail.com> <1448706409-16912-1-git-send-email-sebastian.hesselbarth@gmail.com> Date: Wed, 9 Dec 2015 16:15:52 +0100 Message-ID: Subject: Re: [PATCH v2] pinctrl: mvebu: complain about missing group after checking variant From: Linus Walleij To: Sebastian Hesselbarth Cc: Simon Guinot , Thomas Petazzoni , Jason Cooper , Andrew Lunn , Gregory Clement , "linux-gpio@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1629 Lines: 41 On Sat, Nov 28, 2015 at 11:26 AM, Sebastian Hesselbarth wrote: > Common MVEBU pinctrl driver core gets an array of controls to modify > a specific set of registers and an array of modes for each pingroup > from each of the different SoC families of MVEBU. > > Some SoC families comprise different variants that differ in available > pingroups and also controls, but to ease driver development, we can > pass a variant mask to disable specific pingroups for some variants. > However, controls are limited to the true number of pinctrl groups > avaiable on a variant. > > Now, when pinctrl core driver parses over above arrays, it tries to > match modes with available controls and complains about missing > controls for modes that are passed to the core but actually are not > avaiable on a variant with: > > kirkwood-pinctrl f1010000.pin-controller: unknown pinctrl group 36 > > This warning is a false-positive and annoying, so move the warning > after we checked the variant mask for each mode setting. Also, if > there is no supported setting for this variant, do not complain at > all. > > Signed-off-by: Sebastian Hesselbarth > Reported-by: Linus Walleij > --- > Changelog: > v1->v2: > - modify settings loop to allow to check for !num_settings Patch applied! Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/