Subject: Re: [PATCH] powerpc/nvram: Fix a memory leak in err path
To: xinhui <xinhui.pan@linux.vnet.ibm.com>, linuxppc-dev@lists.ozlabs.org,
        linux-kernel@vger.kernel.org
References: <5667FBD5.2050206@linux.vnet.ibm.com>
Cc: Andrzej Hajda <a.hajda@samsung.com>,
        Christophe Jaillet <christophe.jaillet@wanadoo.fr>,
        Hari Bathini <hbathini@linux.vnet.ibm.com>,
        Paul Mackerras <paulus@samba.org>
From: Nathan Fontenot <nfont@linux.vnet.ibm.com>
Message-ID: <566846F5.2020507@linux.vnet.ibm.com>
Date: Wed, 9 Dec 2015 09:21:25 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.1.0
MIME-Version: 1.0
In-Reply-To: <5667FBD5.2050206@linux.vnet.ibm.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1143
Lines: 35

On 12/09/2015 04:00 AM, xinhui wrote:
> 
> If kmemdup fails, We need kfree *buff* first then return -ENOMEM.
> Otherwise there is a memory leak.
> 
> Signed-off-by: Pan Xinhui <xinhui.pan@linux.vnet.ibm.com>

Reviewed-by: Nathan Fontenot <nfont@linux.vnet.ibm.com>

> ---
>  arch/powerpc/kernel/nvram_64.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/powerpc/kernel/nvram_64.c b/arch/powerpc/kernel/nvram_64.c
> index 32e2652..21a278b7 100644
> --- a/arch/powerpc/kernel/nvram_64.c
> +++ b/arch/powerpc/kernel/nvram_64.c
> @@ -542,9 +542,9 @@ static ssize_t nvram_pstore_read(u64 *id, enum pstore_type_id *type,
>  			time->tv_nsec = 0;
>  		}
>  		*buf = kmemdup(buff + hdr_size, length, GFP_KERNEL);
> +		kfree(buff);
>  		if (*buf == NULL)
>  			return -ENOMEM;
> -		kfree(buff);
>  
>  		if (err_type == ERR_TYPE_KERNEL_PANIC_GZ)
>  			*compressed = true;
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/