Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752616AbbLIRAA (ORCPT ); Wed, 9 Dec 2015 12:00:00 -0500 Received: from mail.kernel.org ([198.145.29.136]:33589 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751874AbbLIQ76 (ORCPT ); Wed, 9 Dec 2015 11:59:58 -0500 Date: Wed, 9 Dec 2015 10:59:54 -0600 From: Bjorn Helgaas To: Phil Edworthy Cc: Bjorn Helgaas , Wolfram Sang , Geert Uytterhoeven , Simon Horman , "linux-pci@vger.kernel.org" , "linux-sh@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [Resend: PATCH v2 0/3] Fix rcar-pcie for arm64 Message-ID: <20151209165954.GG31930@localhost> References: <1448465439-2132-1-git-send-email-phil.edworthy@renesas.com> <20151125164033.GA1380@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4037 Lines: 96 On Thu, Nov 26, 2015 at 08:32:43AM +0000, Phil Edworthy wrote: > HI Bjorn, > > On 25 November 2015 16:41, Bjorn Helgaas wrote: > > Hi Phil, > > > > On Wed, Nov 25, 2015 at 03:30:36PM +0000, Phil Edworthy wrote: > > > The first patches fixes the build problem > > > > I'm trying to figure out if v4.4 has a build problem we need to fix. > > If I understand correctly, "PCI: rcar: Convert to DT resource parsing > > API" doesn't fix a build problem in the current tree; rather, it > > removes a dependency on ARM so that we can build it on ARM64. > v4.4 doesn't have a build problem because commit 7c537c67d2e4 ensures > it doesn't get built on arm64. If we revert this commit, then there is a > build failure as the pci_ioremap_io() function is not available on arm64. > That's the build failure which "PCI: rcar: Convert to DT resource parsing API" > fixes. > > > > , and the second patch reverts the > > > patch that removed the driver from arm64 builds. The final patch add a compat > > > string for the r8a7795 (arm64) device. > > > > > > Tested on arm Koelsch board, all ok. > > > > > > Tested on arm64 Salvator-X board using renesas-drivers-2015-10-27-v4.3-rc7 > > from > > > git://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git with > > PCI > > > next merged. > > > Apart from patches to add the PCIe clock and DT nodes, it also needs this fix: > > > ("PCI: MSI: Only use the generic MSI layer when domain is hierarchical") > > > > I assume you mean this one from Marc: https://lkml.org/lkml/2015/11/23/388 > > (Was that posted to linux-pci? I don't see it in patchwork or my > > linux-pci archives, so I hadn't seen it yet.) > Ok, yes that's the patch. > > > How exactly is that related to this series? If I merge these before > > Marc's change, do we have a tree that builds for arm64 but doesn't > > work? > Correct. OK, great! I just asked Linus to pull that patch (3845d2953aac ("PCI/MSI: Only use the generic MSI layer when domain is hierarchical")) for v4.4, so these changes will be merged after that one. I put all three of these on pci/host-rcar for v4.5. Simon, I only see your explicit ack on the first one, but I assume you're OK with all three. Let me know if otherwise. > > What about the PCIe clock and DT changes you mention? Is there a > > reason to keep them separate? Would it be feasible to include the DT > > changes in the same patch as the driver change that uses those > > changes? > The approach for all other drivers has been to keep these separate. There > are no changes to the dt bindings, it's just adding the node to the new > device and board, so there is no problem with ordering of these patches. > > Thanks > Phil > > > Bjorn > > > > > Resent with whole series marked as v2 and acks, etc added. > > > > > > Harunobu Kurokawa (1): > > > PCI: pcie-rcar: Add support for R-Car H3. > > > > > > Phil Edworthy (2): > > > PCI: rcar: Convert to DT resource parsing API > > > Revert "PCI: rcar: Build pcie-rcar.c only on ARM" > > > > > > Documentation/devicetree/bindings/pci/rcar-pci.txt | 3 +- > > > drivers/pci/host/Kconfig | 3 +- > > > drivers/pci/host/pcie-rcar.c | 117 +++++++++++++-------- > > > 3 files changed, 77 insertions(+), 46 deletions(-) > > > > > > -- > > > 2.5.0 > > > > > > -- > > > To unsubscribe from this list: send the line "unsubscribe linux-pci" in > > > the body of a message to majordomo@vger.kernel.org > > > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/