Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752828AbbLIROa (ORCPT ); Wed, 9 Dec 2015 12:14:30 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:55180 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752446AbbLIRO2 (ORCPT ); Wed, 9 Dec 2015 12:14:28 -0500 Message-ID: <56686171.5060102@codeaurora.org> Date: Wed, 09 Dec 2015 12:14:25 -0500 From: Christopher Covington User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:36.0) Gecko/20100101 Thunderbird/36.0 MIME-Version: 1.0 To: Sinan Kaya , Andy Shevchenko CC: "linux-acpi@vger.kernel.org" , Timur Tabi , jcm@redhat.com, helgaas@kernel.org, "Rafael J. Wysocki" , Len Brown , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH V9 1/2] ACPI, PCI, irq: remove interrupt count restriction References: <1449677909-12432-1-git-send-email-okaya@codeaurora.org> <1449677909-12432-2-git-send-email-okaya@codeaurora.org> <56686037.70109@codeaurora.org> In-Reply-To: <56686037.70109@codeaurora.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1439 Lines: 37 Hi Sinan, On 12/09/2015 12:09 PM, Sinan Kaya wrote: > On 12/9/2015 11:59 AM, Andy Shevchenko wrote: >>> + if (trigger != ACPI_MADT_TRIGGER_LEVEL || >>>> + polarity != ACPI_MADT_POLARITY_ACTIVE_LOW) >>>> + penalty = PIRQ_PENALTY_ISA_ALWAYS; >>>> + else >>>> + penalty = PIRQ_PENALTY_PCI_USING; >>>> + >>>> + acpi_irq_add_penalty(irq, penalty); >> Why not to change in place? I think a common sense rule is not to >> change something existing if it doesn't add any significant value. >> > Sorry, I didn't understand what you mean. Are you asking why we are > changing lines like above? > > If yes, acpi_irq_penalty used to be an array of 256 entries. Now, > acpi_irq_penalty doesn't exist anymore as it was replaced with a linklist. > >> - acpi_irq_penalty[irq] += PIRQ_PENALTY_PCI_USING; >> + acpi_irq_add_penalty(irq, PIRQ_PENALTY_PCI_USING); I think Andy was suggesting that you make the change without introducing the penalty variable. Christopher Covington -- Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/