Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752738AbbLIRRJ (ORCPT ); Wed, 9 Dec 2015 12:17:09 -0500 Received: from mail-pf0-f170.google.com ([209.85.192.170]:34751 "EHLO mail-pf0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752446AbbLIRRI (ORCPT ); Wed, 9 Dec 2015 12:17:08 -0500 Date: Wed, 9 Dec 2015 09:17:04 -0800 From: Dmitry Torokhov To: Steve Twiss Cc: LINUX-INPUT , LINUXKERNEL , David Dajun Chen , Support Opensource Subject: Re: [PATCH V1] input: da9063: report KEY_POWER instead of KEY_SLEEP during power key-press Message-ID: <20151209171704.GB27131@dtor-ws> References: <20151208180554.F29B93FB25@swsrvapps-01.diasemi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151208180554.F29B93FB25@swsrvapps-01.diasemi.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1798 Lines: 55 On Tue, Dec 08, 2015 at 05:55:05PM +0000, Steve Twiss wrote: > From: Steve Twiss > > Stop reporting KEY_SLEEP for a short key-press and report KEY_POWER instead > This change applied to both DA9063 and DA9062 ONKEY drivers. You need to explain why this change is needed. > > Signed-off-by: Steve Twiss > > --- > > This patch applies against linux-next and v4.4-rc4 > > Regards, > Steve > > > drivers/input/misc/da9063_onkey.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/input/misc/da9063_onkey.c b/drivers/input/misc/da9063_onkey.c > index 8eb697d..bb863e0 100644 > --- a/drivers/input/misc/da9063_onkey.c > +++ b/drivers/input/misc/da9063_onkey.c > @@ -179,13 +179,13 @@ static irqreturn_t da9063_onkey_irq_handler(int irq, void *data) > input_report_key(onkey->input, KEY_POWER, 1); > input_sync(onkey->input); > schedule_delayed_work(&onkey->work, 0); > - dev_dbg(onkey->dev, "KEY_POWER pressed.\n"); > + dev_dbg(onkey->dev, "KEY_POWER long press.\n"); > } else { > - input_report_key(onkey->input, KEY_SLEEP, 1); > + input_report_key(onkey->input, KEY_POWER, 1); > input_sync(onkey->input); > - input_report_key(onkey->input, KEY_SLEEP, 0); > + input_report_key(onkey->input, KEY_POWER, 0); > input_sync(onkey->input); > - dev_dbg(onkey->dev, "KEY_SLEEP pressed.\n"); > + dev_dbg(onkey->dev, "KEY_POWER short press.\n"); > } > > return IRQ_HANDLED; > -- > end-of-patch for PATCH V1 > -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/