Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753231AbbLISL0 (ORCPT <rfc822;w@1wt.eu>);
	Wed, 9 Dec 2015 13:11:26 -0500
Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:11205 "EHLO
	mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1752897AbbLISLY (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 9 Dec 2015 13:11:24 -0500
X-IronPort-AV: E=Sophos;i="5.20,404,1444687200"; 
   d="scan'208";a="191233853"
Date: Wed, 9 Dec 2015 19:11:15 +0100 (CET)
From: Julia Lawall <julia.lawall@lip6.fr>
X-X-Sender: jll@hadrien
To: Dan Carpenter <dan.carpenter@oracle.com>
cc: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>,
        "James E.J. Bottomley" <JBottomley@odin.com>,
        Ondrej Zary <linux@rainbow-software.org>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
        kernel-janitors@vger.kernel.org, Hannes Reinecke <hare@suse.com>
Subject: Re: [patch RESEND] atp870u: 64 bit bug in atp885_init()
In-Reply-To: <20151209174819.GB5177@mwanda>
Message-ID: <alpine.DEB.2.10.1512091907590.2491@hadrien>
References: <55B9CA3B.1030205@suse.de> <20151209102453.GE3173@mwanda> <20151209115339.46a09d94@lxorguk.ukuu.org.uk> <20151209134512.GA5177@mwanda> <20151209141459.41a237c9@lxorguk.ukuu.org.uk> <20151209174819.GB5177@mwanda>
User-Agent: Alpine 2.10 (DEB 1266 2009-07-14)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1060
Lines: 28



On Wed, 9 Dec 2015, Dan Carpenter wrote:

> We should add a tag to indicate that we are sending a patch for a crappy
> driver.
>
> IMHO-this-driver-is-garbage: Your Name <email>
>
> If it got 10 votes of no confidence it would be moved to staging and
> then deleted.

Forgive my ignorance, but what is the exact procedure?  For example, the
following file: drivers/pcmcia/vrc4173_cardu.c contains the following
code: INIT_WORK(&socket->tq_work, cardu_bh, socket);.  The last time
INIT_WORK took three arguments was Linux 2.6.19, so I think no one has
been compiling this code recently.  There would be the .c file and the
associated .h file to move to staging, but it's less clear to me eg what
to do with the Kconfig entry and the Makefile entry.  And is there
anything else to take into account?

thanks,
julia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/