Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753543AbbLITJU (ORCPT ); Wed, 9 Dec 2015 14:09:20 -0500 Received: from mail.skyhub.de ([78.46.96.112]:34077 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752775AbbLITJT (ORCPT ); Wed, 9 Dec 2015 14:09:19 -0500 Date: Wed, 9 Dec 2015 20:09:04 +0100 From: Borislav Petkov To: Andy Lutomirski Cc: Andy Lutomirski , X86 ML , "linux-kernel@vger.kernel.org" , Brian Gerst , =?utf-8?B?RnLDqWTDqXJpYw==?= Weisbecker , Denys Vlasenko , Linus Torvalds Subject: Re: [PATCH 02/12] selftests/x86: Add check_initial_reg_state Message-ID: <20151209190904.GB10475@pd.tnic> References: <20151208095455.GC27180@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 982 Lines: 34 On Wed, Dec 09, 2015 at 10:56:36AM -0800, Andy Lutomirski wrote: > That was intentional -- everything lines up with the top-level "asm(". > checkpatch is confused because it understands "\t " at the front of a > line but not just a space. > > That being said, I could easily be convinced to switch to tabs there. I'd say kernel coding style is tabs of 8 chars... You could do asm(".pushsection .text\n\t" ".type real_start, @function\n\t" ".global real_start\n\t" "real_start:\n\t" #ifdef __x86_64__ "mov %rax, ax\n\t" "mov %rbx, bx\n\t" ... and align the opening "asm(" to the first tab... Bah, whatever, I'm not that finicky to care enough. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/