Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754039AbbLITLq (ORCPT ); Wed, 9 Dec 2015 14:11:46 -0500 Received: from mail-wm0-f49.google.com ([74.125.82.49]:38311 "EHLO mail-wm0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753561AbbLITLo (ORCPT ); Wed, 9 Dec 2015 14:11:44 -0500 Subject: Re: [PATCH v2 1/1] drm: modes: fix DRM modes analysis regression To: Jani Nikula , airlied@linux.ie References: <1449667811-24472-1-git-send-email-clabbe.montjoie@gmail.com> <1449667811-24472-2-git-send-email-clabbe.montjoie@gmail.com> <871tavwscq.fsf@intel.com> Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org From: Corentin LABBE X-Enigmail-Draft-Status: N1110 Message-ID: <56687CEB.9060007@gmail.com> Date: Wed, 9 Dec 2015 20:11:39 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <871tavwscq.fsf@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1290 Lines: 30 Le 09/12/2015 16:32, Jani Nikula a ?crit : > On Wed, 09 Dec 2015, LABBE Corentin wrote: >> My latest commit introduce some case where a valid mode, could be >> rejected. >> simple_strtox functions stop at first non-digit character, but kstrtox not. >> So args like "video=HDMI-A-1:720x480-16@60" will be reject when checking 16@. >> The proper solution is to store digits in a specific buffer. > > Or to revert regressing commit...? Your original commit complicated the > already complicated function, and this one makes it more so. What is the > benefit? > The benefit is to remove a function marked obsolete who do not said if the conversation is successful or not. But I understand that the way I have done it was not the best one. If the maintainer want it, I will send a patch for reverting the first patch. >> Fixes: 52157a4ca396 ("drm: modes: replace simple_strtoul by kstrtouint") > > For me the commit id is cc344980c76748e57c9c03100c2a14d36ab00334. Oups, I took commit id from my local git. Regards -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/