Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754024AbbLITTx (ORCPT ); Wed, 9 Dec 2015 14:19:53 -0500 Received: from www62.your-server.de ([213.133.104.62]:35497 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753954AbbLITTv (ORCPT ); Wed, 9 Dec 2015 14:19:51 -0500 Message-ID: <56687EBB.5040108@iogearbox.net> Date: Wed, 09 Dec 2015 20:19:23 +0100 From: Daniel Borkmann User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Marcelo Ricardo Leitner , David Laight , "'Eric Dumazet'" CC: Eric Dumazet , Dmitry Vyukov , "David S. Miller" , Alexey Kuznetsov , James Morris , Hideaki YOSHIFUJI , Patrick McHardy , netdev , LKML , Vlad Yasevich , Neil Horman , "linux-sctp@vger.kernel.org" , syzkaller , Kostya Serebryany , Alexander Potapenko , Sasha Levin Subject: Re: [PATCH net] ipv6: sctp: clone options to avoid use after free References: <20151209145917.GA3884@mrl.redhat.com> <1449674706.9768.5.camel@edumazet-glaptop2.roam.corp.google.com> <063D6719AE5E284EB5DD2968C1650D6D1CBE9A61@AcuExch.aculab.com> <1449676782.9768.9.camel@edumazet-glaptop2.roam.corp.google.com> <063D6719AE5E284EB5DD2968C1650D6D1CBE9B1C@AcuExch.aculab.com> <566860BC.4040604@gmail.com> In-Reply-To: <566860BC.4040604@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1555 Lines: 34 On 12/09/2015 06:11 PM, Marcelo Ricardo Leitner wrote: > Em 09-12-2015 14:31, David Laight escreveu: >> From: Eric Dumazet [mailto:eric.dumazet@gmail.com] >>> Sent: 09 December 2015 16:00 >>> On Wed, 2015-12-09 at 15:49 +0000, David Laight wrote: >>>>> SCTP is lacking proper np->opt cloning at accept() time. >>>>> >>>>> TCP and DCCP use ipv6_dup_options() helper, do the same in SCTP. >>>>> >>>>> We might later factorize this code in a common helper to avoid >>>>> future mistakes. >>>> >>>> I'm wondering what the real impact of this and the other recent >>>> SCTP bugs/patches is on real workloads? >>>> We have enough trouble getting our customers to use kernels >>>> later that the 2.6.18 based RHEL5 - without having to persuade >>>> them to use kernels that contain very recent fixes. >>> >>> It all depends if your customers let (hostile ?) people run programs on >>> the boxes. >> >> If they require hostile programs I'm not worried. > > Not really "require", but "allow", as in: allowing third-party applications to run on it. Yeah :/ given distros enable almost everything anyway, the first unpriv'ed socket(..., IPPROTO_SCTP) call auto-loads SCTP module. But to be honest, I'd be surprised if Cloud providers allow for this. Most of this might only run on dedicated boxes with telco appliances. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/