Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752895AbbLIUPs (ORCPT ); Wed, 9 Dec 2015 15:15:48 -0500 Received: from mail-vk0-f53.google.com ([209.85.213.53]:33192 "EHLO mail-vk0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751319AbbLIUPo (ORCPT ); Wed, 9 Dec 2015 15:15:44 -0500 MIME-Version: 1.0 In-Reply-To: <56688A9B.9080607@cogentembedded.com> References: <1449691056-32238-1-git-send-email-geyslan@gmail.com> <1449691056-32238-3-git-send-email-geyslan@gmail.com> <56688A9B.9080607@cogentembedded.com> Date: Wed, 9 Dec 2015 17:15:43 -0300 Message-ID: Subject: Re: [PATCH 3/4] usb: host: ehci.h: remove duplicated return From: "Geyslan G. Bem" To: Sergei Shtylyov Cc: Peter Senna Tschudin , Alan Stern , Greg Kroah-Hartman , linux-usb@vger.kernel.org, LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1514 Lines: 57 2015-12-09 17:10 GMT-03:00 Sergei Shtylyov : > Hello. > > On 12/09/2015 10:57 PM, Geyslan G. Bem wrote: > >> This patch removes the return of the default switch case, since >> 'ehci_port_speed()' already has the same default return. >> >> Signed-off-by: Geyslan G. Bem >> --- >> drivers/usb/host/ehci.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/usb/host/ehci.h b/drivers/usb/host/ehci.h >> index 0daed80..49b91b6 100644 >> --- a/drivers/usb/host/ehci.h >> +++ b/drivers/usb/host/ehci.h >> @@ -664,8 +664,8 @@ ehci_port_speed(struct ehci_hcd *ehci, unsigned int >> portsc) >> case 1: >> return USB_PORT_STAT_LOW_SPEED; >> case 2: >> + /* fall through to default function return */ > > > We just don't need the above *case*. > >> default: >> - return USB_PORT_STAT_HIGH_SPEED; > > > And n ow we don't need *dafault* too. Case 1 only? If not low_speed, high_speed. So, I'll change it to a simple if branch. > >> } >> } >> return USB_PORT_STAT_HIGH_SPEED; > > > MBR, Sergei > -- Regards, Geyslan G. Bem hackingbits.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/