Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752080AbbLIUss (ORCPT ); Wed, 9 Dec 2015 15:48:48 -0500 Received: from mx2.suse.de ([195.135.220.15]:48566 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750973AbbLIUsq (ORCPT ); Wed, 9 Dec 2015 15:48:46 -0500 Subject: Re: [PATCH v2 1/3] mm, printk: introduce new format string for flags To: Arnd Bergmann References: <87io4hi06n.fsf@rasmusvillemoes.dk> <1449242195-16374-1-git-send-email-vbabka@suse.cz> <9558837.lN284KClUg@wuerfel> Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Joonsoo Kim , Minchan Kim , Sasha Levin , "Kirill A. Shutemov" , Mel Gorman , Michal Hocko , Rasmus Villemoes , Andi Kleen From: Vlastimil Babka X-Enigmail-Draft-Status: N1110 Message-ID: <566893A9.7050704@suse.cz> Date: Wed, 9 Dec 2015 21:48:41 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <9558837.lN284KClUg@wuerfel> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2537 Lines: 66 On 12/09/2015 12:29 PM, Arnd Bergmann wrote: > On Friday 04 December 2015 16:16:33 Vlastimil Babka wrote: >> --- a/include/linux/mmdebug.h >> +++ b/include/linux/mmdebug.h >> @@ -2,15 +2,20 @@ >> #define LINUX_MM_DEBUG_H 1 >> >> #include >> +#include >> +#include > > 8<----- > Subject: mm: fix generated/bounds.h > > The inclusion of linux/tracepoint.h is causing build errors for me in ARM > randconfig: > > In file included from /git/arm-soc/include/linux/ktime.h:25:0, > from /git/arm-soc/include/linux/rcupdate.h:47, > from /git/arm-soc/include/linux/tracepoint.h:19, > from /git/arm-soc/include/linux/mmdebug.h:6, > from /git/arm-soc/include/linux/page-flags.h:10, > from /git/arm-soc/kernel/bounds.c:9: > /git/arm-soc/include/linux/jiffies.h:10:33: fatal error: generated/timeconst.h: No such file or directory > compilation terminated. > > To work around this, we can stop including linux/mmdebug.h from linux/page_flags.h > while generating bounds.h, as we do for mm_types.h already. > > Signed-off-by: Arnd Bergmann Thanks and sorry. Andrew can you please include it in mmotm as -fix for now? I plan to respin the whole of this later with some patch splitting and reordering to reduce churn and follow Rasmus' advice. Also I've just learned that there's a new lightweight tracepoint-defs.h in -tip thanks to Andi, which would be a better place for struct trace_print_flags than tracepoint.h is, so I'll look into using it for the respin, which should make this temporary -fix redundant. > Fixes: 8c0d593d0f8f ("mm, printk: introduce new format string for flags") Note that the linux-next commit id is volatile here (regenerated from quilt series). > > diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h > index 19724e6ebd26..4efad0578a28 100644 > --- a/include/linux/page-flags.h > +++ b/include/linux/page-flags.h > @@ -7,8 +7,8 @@ > > #include > #include > -#include > #ifndef __GENERATING_BOUNDS_H > +#include > #include > #include > #endif /* !__GENERATING_BOUNDS_H */ > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/