Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752198AbbLIU6T (ORCPT ); Wed, 9 Dec 2015 15:58:19 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:39619 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751303AbbLIU6S (ORCPT ); Wed, 9 Dec 2015 15:58:18 -0500 Date: Wed, 09 Dec 2015 15:58:13 -0500 (EST) Message-Id: <20151209.155813.321840735475652944.davem@davemloft.net> To: festevam@gmail.com Cc: timur@codeaurora.org, gavidov@codeaurora.org, gregkh@linuxfoundation.org, netdev@vger.kernel.org, sdharia@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, vikrams@codeaurora.org, shankerd@codeaurora.org Subject: Re: [PATCH] net: emac: emac gigabit ethernet controller driver From: David Miller In-Reply-To: References: <1449529094-10922-1-git-send-email-gavidov@codeaurora.org> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 09 Dec 2015 12:58:17 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 820 Lines: 28 From: Fabio Estevam Date: Wed, 9 Dec 2015 18:37:35 -0200 > On Wed, Dec 9, 2015 at 6:09 PM, Timur Tabi wrote: > >>> +/* set MAC address */ >>> +void emac_mac_addr_clear(struct emac_adapter *adpt, u8 *addr) >>> +{ >>> + u32 sta; >>> + >>> + /* for example: 00-A0-C6-11-22-33 >>> + * 0<-->C6112233, 1<-->00A0. >>> + */ >> >> /* >> * Multi-line comments >> * look like this. >> */ > > Except in drivers/net. The convention in drivers/net is to use > multi-line format as posted in this patch. Correct. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/