Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752482AbbLIVMT (ORCPT ); Wed, 9 Dec 2015 16:12:19 -0500 Received: from mail-ig0-f174.google.com ([209.85.213.174]:37514 "EHLO mail-ig0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751354AbbLIVMR (ORCPT ); Wed, 9 Dec 2015 16:12:17 -0500 MIME-Version: 1.0 In-Reply-To: <1449628714-66641-1-git-send-email-computersforpeace@gmail.com> References: <1449628714-66641-1-git-send-email-computersforpeace@gmail.com> Date: Wed, 9 Dec 2015 13:12:16 -0800 X-Google-Sender-Auth: nAFU-6k7_BvlFSVlmDhmKzQDuds Message-ID: Subject: Re: [PATCH 1/4] test: firmware_class: report errors properly on failure From: Kees Cook To: Brian Norris Cc: Shuah Khan , Greg Kroah-Hartman , Ming Lei , LKML , Linux API , "Luis R. Rodriguez" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1984 Lines: 68 On Tue, Dec 8, 2015 at 6:38 PM, Brian Norris wrote: > request_firmware() failures currently won't get reported at all (the > error code is discarded). What's more, we get confusing messages, like: > > # echo -n notafile > /sys/devices/virtual/misc/test_firmware/trigger_request > [ 8280.311856] test_firmware: loading 'notafile' > [ 8280.317042] test_firmware: load of 'notafile' failed: -2 > [ 8280.322445] test_firmware: loaded: 0 > # echo $? > 0 > > Report the failures via write() errors, and don't say we "loaded" > anything. > > Signed-off-by: Brian Norris Yeah, good called. Acked-by: Kees Cook -Kees > --- > lib/test_firmware.c | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/lib/test_firmware.c b/lib/test_firmware.c > index 86374c1c49a4..841191061816 100644 > --- a/lib/test_firmware.c > +++ b/lib/test_firmware.c > @@ -65,14 +65,19 @@ static ssize_t trigger_request_store(struct device *dev, > release_firmware(test_firmware); > test_firmware = NULL; > rc = request_firmware(&test_firmware, name, dev); > - if (rc) > + if (rc) { > pr_info("load of '%s' failed: %d\n", name, rc); > - pr_info("loaded: %zu\n", test_firmware ? test_firmware->size : 0); > + goto out; > + } > + pr_info("loaded: %zu\n", test_firmware->size); > + rc = count; > + > +out: > mutex_unlock(&test_fw_mutex); > > kfree(name); > > - return count; > + return rc; > } > static DEVICE_ATTR_WO(trigger_request); > > -- > 2.6.0.rc2.230.g3dd15c0 > -- Kees Cook Chrome OS & Brillo Security -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/