Message-ID: <1449695786.25389.67.camel@perches.com>
Subject: Re: [PATCHv2] printf: Add format for 8-byte EUI-64 type
From: Joe Perches <joe@perches.com>
To: Keith Busch <keith.busch@intel.com>, linux-nvme@lists.infradead.org,
        LKML <linux-kernel@vger.kernel.org>
Cc: Matthew Wilcox <willy@linux.intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jens Axboe <axboe@fb.com>, Christoph Hellwig <hch@infradead.org>,
        Dan Williams <dan.j.williams@intel.com>
Date: Wed, 09 Dec 2015 13:16:26 -0800
In-Reply-To: <1449695357-22163-1-git-send-email-keith.busch@intel.com>
References: <1449695357-22163-1-git-send-email-keith.busch@intel.com>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1525
Lines: 52

On Wed, 2015-12-09 at 14:09 -0700, Keith Busch wrote:
> MAC addresses may be formed using rules based on EUI-64, which is 2 bytes
> longer than a typical 6-byte MAC. This patch adds a long specifier to
> the %pM format to support the extended unique identifier.
> 
> Since there are now two cases that use the default ':' separator, this
> initializes the separator during its declaration, and removes the switch
> fall through case.
> 
> Signed-off-by: Keith Busch <keith.busch@intel.com>
> ---
> Changed from previos version:
> 
> ? Fixed checks for the 'l' specifier. This can be in fmt[1] or fmt[2],
> ? pointed out by Joe Perches from original review (thanks!).
[]
> diff --git a/lib/vsprintf.c b/lib/vsprintf.c
[]
> @@ -902,20 +902,33 @@ char *mac_address_string(char *buf, char *end, u8 *addr,
> ?
> ?	case 'R':
> ?		reversed = true;
> -		/* fall through */
> +		break;
> +
> +	case 'l':
> +		bytes = 8;
> +		break;
> ?
> ?	default:
> -		separator = ':';
> ?		break;
> ?	}
> +	if (separator == '-' || reversed) {
> +		/* 'F' and 'R' may take additional length specifier */
> +		switch (fmt[2]) {
> +		case 'l':
> +			bytes = 8;
> +			break;
> +		default:
> +			break;
> +		}
> +	}
> 

Using a while (isalpha(*++fmt)) loop like ip6_addr_string_sa
would probably be simpler.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/