Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Wed, 5 Mar 2003 20:14:29 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Wed, 5 Mar 2003 20:14:29 -0500 Received: from neon-gw-l3.transmeta.com ([63.209.4.196]:11525 "EHLO neon-gw.transmeta.com") by vger.kernel.org with ESMTP id ; Wed, 5 Mar 2003 20:14:25 -0500 Date: Wed, 5 Mar 2003 17:22:20 -0800 (PST) From: Linus Torvalds To: Andries.Brouwer@cwi.nl cc: linux-kernel@vger.kernel.org, Subject: Re: 2.5.63/64 do not boot: loop in scsi_error In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1865 Lines: 53 On Thu, 6 Mar 2003 Andries.Brouwer@cwi.nl wrote: > > See that 2.5.64 came out - good. Time to send the next dev_t patch. > Unfortunately 2.5.63 and 2.5.64 do not boot. > > A moment ago I looked at what goes wrong, and it turns out that > scsi_error is activated See if this fixes it.. Linus --- # This is a BitKeeper generated patch for the following project: # Project Name: Linux kernel tree # This patch format is intended for GNU patch command version 2.5 or higher. # This patch includes the following deltas: # ChangeSet 1.1088 -> 1.1089 # drivers/scsi/scsi_error.c 1.38 -> 1.39 # # The following is the BitKeeper ChangeSet Log # -------------------------------------------- # 03/03/05 andmike@us.ibm.com 1.1089 # [PATCH] Fix SCSI error handler abort case # # I had my list empty checks reversed if aborting and bus device reset # failed. The condition that causes the error handler to run is still # unknown. # -------------------------------------------- # diff -Nru a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c --- a/drivers/scsi/scsi_error.c Wed Mar 5 17:21:56 2003 +++ b/drivers/scsi/scsi_error.c Wed Mar 5 17:21:56 2003 @@ -1490,9 +1490,9 @@ struct list_head *work_q, struct list_head *done_q) { - if (scsi_eh_bus_device_reset(shost, work_q, done_q)) - if (scsi_eh_bus_reset(shost, work_q, done_q)) - if (scsi_eh_host_reset(work_q, done_q)) + if (!scsi_eh_bus_device_reset(shost, work_q, done_q)) + if (!scsi_eh_bus_reset(shost, work_q, done_q)) + if (!scsi_eh_host_reset(work_q, done_q)) scsi_eh_offline_sdevs(work_q, done_q); } - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/