Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753802AbbLIVtH (ORCPT ); Wed, 9 Dec 2015 16:49:07 -0500 Received: from mail-vk0-f52.google.com ([209.85.213.52]:36703 "EHLO mail-vk0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752723AbbLIVrO (ORCPT ); Wed, 9 Dec 2015 16:47:14 -0500 MIME-Version: 1.0 In-Reply-To: <201512100543.88aNx6Km%fengguang.wu@intel.com> References: <1449691056-32238-3-git-send-email-geyslan@gmail.com> <201512100543.88aNx6Km%fengguang.wu@intel.com> Date: Wed, 9 Dec 2015 18:47:13 -0300 Message-ID: Subject: Re: [PATCH 3/4] usb: host: ehci.h: remove duplicated return From: "Geyslan G. Bem" To: kbuild test robot Cc: kbuild-all@01.org, Peter Senna Tschudin , Alan Stern , Greg Kroah-Hartman , linux-usb@vger.kernel.org, LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2492 Lines: 67 2015-12-09 18:24 GMT-03:00 kbuild test robot : > Hi Geyslan, > > [auto build test ERROR on usb/usb-testing] > [also build test ERROR on v4.4-rc4 next-20151209] > > url: https://github.com/0day-ci/linux/commits/Geyslan-G-Bem/usb-host-ehci-h-cleanup-header-file/20151210-040115 > base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing > config: x86_64-randconfig-s0-12100345 (attached as .config) > reproduce: > # save the attached .config to linux build tree > make ARCH=x86_64 > > All errors (new ones prefixed by >>): > > In file included from drivers/usb/chipidea/host.c:29:0: > drivers/usb/chipidea/../host/ehci.h: In function 'ehci_port_speed': >>> drivers/usb/chipidea/../host/ehci.h:668:3: error: label at end of compound statement > default: Missed the break. Coul be removed too. > ^ > > vim +668 drivers/usb/chipidea/../host/ehci.h > > ^1da177e Linus Torvalds 2005-04-16 662 case 0: > ^1da177e Linus Torvalds 2005-04-16 663 return 0; > ^1da177e Linus Torvalds 2005-04-16 664 case 1: > 288ead45 Alan Stern 2010-03-04 665 return USB_PORT_STAT_LOW_SPEED; > ^1da177e Linus Torvalds 2005-04-16 666 case 2: > 50691528 Geyslan G. Bem 2015-12-09 667 /* fall through to default function return */ > ^1da177e Linus Torvalds 2005-04-16 @668 default: > ^1da177e Linus Torvalds 2005-04-16 669 } > ^1da177e Linus Torvalds 2005-04-16 670 } > 288ead45 Alan Stern 2010-03-04 671 return USB_PORT_STAT_HIGH_SPEED; > > :::::: The code at line 668 was first introduced by commit > :::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2 > > :::::: TO: Linus Torvalds > :::::: CC: Linus Torvalds > > --- > 0-DAY kernel test infrastructure Open Source Technology Center > https://lists.01.org/pipermail/kbuild-all Intel Corporation > No, please leave it as-is, it helps to understand what is going on here > easier. Ok. Let it go. :) > thanks, > greg k-h -- Regards, Geyslan G. Bem hackingbits.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/