Subject: Re: [PATCH 3.16.y-ckt 059/126] thermal: exynos: Fix unbalanced
 regulator disable on probe failure
To: Luis Henriques <luis.henriques@canonical.com>
References: <1449653896-5236-1-git-send-email-luis.henriques@canonical.com>
 <1449653896-5236-60-git-send-email-luis.henriques@canonical.com>
 <56682B1D.9090707@samsung.com> <20151209135952.GA4797@ares>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        kernel-team@lists.ubuntu.com, k.kozlowski.k@gmail.com,
        Eduardo Valentin <edubezval@gmail.com>
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Message-id: <5668CBD0.9010503@samsung.com>
Date: Thu, 10 Dec 2015 09:48:16 +0900
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.4.0
MIME-version: 1.0
In-reply-to: <20151209135952.GA4797@ares>
Content-type: text/plain; charset=windows-1252
Content-transfer-encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2384
Lines: 61

On 09.12.2015 22:59, Luis Henriques wrote:
> On Wed, Dec 09, 2015 at 10:22:37PM +0900, Krzysztof Kozlowski wrote:
>> W dniu 09.12.2015 o 18:37, Luis Henriques pisze:
>>> 3.16.7-ckt21 -stable review patch.  If anyone has any objections, please let me know.
>>>
>>> ------------------
>>>
>>> From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>>>
>>> commit 824ead03b78403a21449cb7eb153a4344cd3b4c8 upstream.
>>>
>>> During probe if the regulator could not be enabled, the error exit path
>>> would still disable it. This could lead to unbalanced counter of
>>> regulator enable/disable.
>>>
>>> The patch moves code for getting and enabling the regulator from
>>> exynos_map_dt_data() to probe function because it is really not a part
>>> of getting Device Tree properties.
>>>
>>> Acked-by: Lukasz Majewski <l.majewski@samsung.com>
>>> Tested-by: Lukasz Majewski <l.majewski@samsung.com>
>>> Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
>>> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>>> Fixes: 5f09a5cbd14a ("thermal: exynos: Disable the regulator on probe failure")
>>> Signed-off-by: Eduardo Valentin <edubezval@gmail.com>
>>> [ luis: backported to 3.16: adjusted context ]
>>> Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
>>
>> This patch shouldn't be backported before 4.2. It fixes a bug introduced
>> in 4.2: 5f09a5cbd14a.
>>
>> For kernels <4.2 this bug does not exist but fortunately the patch looks
>> harmless. Anyway still for <4.2 I think it shouldn't be ported.
>>
>> Best regards,
>> Krzysztof
>>
> 
> Thank you Krzysztof.
> 
> I understand that this fixes an issue with commit 5f09a5cbd14a ("thermal:
> exynos: Disable the regulator on probe failure"), which was included in
> 4.2.  However, since this commit was also tagged for stable, it has also
> been backported to some stable kernels (at least 3.16.y-ckt and
> 3.19.y-ckt).
> 
> Would you agree that, for this reason, this patch is in fact applicable to
> the 3.16 (and 3.19) kernel?

Ahh, you are right! The 5f09a5cbd14a was backported so this applies to
backporting as well.

Sorry for the noise.

Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/