Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753073AbbLJBhF (ORCPT ); Wed, 9 Dec 2015 20:37:05 -0500 Received: from cmccmta1.chinamobile.com ([221.176.66.79]:4363 "EHLO cmccmta1.chinamobile.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751887AbbLJBhE (ORCPT ); Wed, 9 Dec 2015 20:37:04 -0500 X-RM-TRANSID: 2ee45668d73b537-4afd8 X-RM-SPAM-FLAG: 00000000 X-RM-TRANSID: 2ee15668d73bfb7-11fc7 Message-ID: <5668D760.2040605@cmss.chinamobile.com> Date: Thu, 10 Dec 2015 09:37:36 +0800 From: Xiubo Li User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Mark Brown CC: linux-kernel@vger.kernel.org Subject: Re: [PATCH] regmap: speed up the regcache_init() References: <1449109150-26793-1-git-send-email-lixiubo@cmss.chinamobile.com> <20151208170517.GU5727@sirena.org.uk> <56679D42.3030708@cmss.chinamobile.com> <20151209150552.GC5727@sirena.org.uk> In-Reply-To: <20151209150552.GC5727@sirena.org.uk> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1064 Lines: 28 On 09/12/2015 23:05, Mark Brown wrote: > On Wed, Dec 09, 2015 at 11:17:22AM +0800, Xiubo Li wrote: > >> Yes, usually when the register cache is not used, the number of the >> defaults should be zero, but for some drivers like drv2267.c/led_lp8860.c >> will add the defaults register values though the cache type is >> REGCACHE_NONE for some reasons. > I can't find either of those in the kernel tree... This could be found in the for-next branch of regmap tree. >> This patch may be not the best, but will be a bit meaningful for some >> drivers like drv2267.c/led_lp8860.c for now. > TBH if we're going to do something here it might be as well to print a > warning if something is providing register defaults but no cache. Yes, Agreed. I will enhance this later in another patch, just abandon this one please. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/