Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754267AbbLJHyO (ORCPT ); Thu, 10 Dec 2015 02:54:14 -0500 Received: from LGEAMRELO12.lge.com ([156.147.23.52]:33569 "EHLO lgeamrelo12.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753700AbbLJHxm (ORCPT ); Thu, 10 Dec 2015 02:53:42 -0500 X-Original-SENDERIP: 156.147.1.121 X-Original-MAILFROM: namhyung@kernel.org X-Original-SENDERIP: 10.177.227.17 X-Original-MAILFROM: namhyung@kernel.org From: Namhyung Kim To: Arnaldo Carvalho de Melo Cc: Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , David Ahern , Frederic Weisbecker , Andi Kleen , Stephane Eranian , Adrian Hunter Subject: [PATCH/RFC 06/16] perf top: Get rid of access to hists->lock in perf_top__record_precise_ip() Date: Thu, 10 Dec 2015 16:53:25 +0900 Message-Id: <1449734015-9148-7-git-send-email-namhyung@kernel.org> X-Mailer: git-send-email 2.6.2 In-Reply-To: <1449734015-9148-1-git-send-email-namhyung@kernel.org> References: <1449734015-9148-1-git-send-email-namhyung@kernel.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1453 Lines: 46 It was accessed to release the lock before going to sleep, but now it doesn't go to sleep anymore since warnings will be shown in the display thread. Signed-off-by: Namhyung Kim --- tools/perf/builtin-top.c | 18 ++++-------------- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/tools/perf/builtin-top.c b/tools/perf/builtin-top.c index aafcf27c437e..24a5434e8a0b 100644 --- a/tools/perf/builtin-top.c +++ b/tools/perf/builtin-top.c @@ -355,20 +355,10 @@ static void perf_top__record_precise_ip(struct perf_top *top, pthread_mutex_unlock(¬es->lock); - if (unlikely(err)) { - /* - * This function is now called with hists->lock held. - * Release it before going to sleep. - */ - pthread_mutex_unlock(&he->hists->lock); - - if (err == -ERANGE) - perf_top__request_warning(top, al, WARN_ERANGE); - else if (err == -ENOMEM) - perf_top__request_warning(top, al, WARN_ENOMEM); - - pthread_mutex_lock(&he->hists->lock); - } + if (err == -ERANGE) + perf_top__request_warning(top, al, WARN_ERANGE); + else if (err == -ENOMEM) + perf_top__request_warning(top, al, WARN_ENOMEM); } static void perf_top__show_details(struct perf_top *top) -- 2.6.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/