Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752971AbbLJJF1 (ORCPT ); Thu, 10 Dec 2015 04:05:27 -0500 Received: from szxga01-in.huawei.com ([58.251.152.64]:23513 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751118AbbLJJFN (ORCPT ); Thu, 10 Dec 2015 04:05:13 -0500 Subject: Re: [PATCH v2 4/9] ARM: dts: add dts files for hi3519-demb board To: Arnd Bergmann References: <1449110668-23647-1-git-send-email-xuejiancheng@huawei.com> <5533669.m0KDLq8XOc@wuerfel> <56691C65.6090808@huawei.com> <2721289.3GUub5trUg@wuerfel> CC: , , , , , , , , , , , , , , , , , , , From: xuejiancheng Message-ID: <56693EE2.20501@huawei.com> Date: Thu, 10 Dec 2015 16:59:14 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <2721289.3GUub5trUg@wuerfel> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.217.211] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020203.56693EEF.0050,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 497946b722344a21bdee6598a8041711 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1110 Lines: 33 On 2015/12/10 16:04, Arnd Bergmann wrote: > On Thursday 10 December 2015 14:32:05 xuejiancheng wrote: >>> >>> This is not what I meant. You have to use "syscon" as the most generic >>> "compatible" value here, but should add a machine specific string >>> as a more specific one. "hisilicon,sysctrl" is not appropriate because >>> it does not identify the IP block uniquely, you can only use that >>> in combination with another more specific string. >> >> OK. I will use "hisilicon,hi3519-syscon" and "syscon" as the compatible value >> for the sysctrl node in hi3519.dtsi. >> > > Why hisilicon,hi3519-syscon instead of hisilicon,hi3519-sysctrl? > Is this not called a sysctrl at all in the datasheet then? It is OK to use hisilicon,hi3519-sysctrl. I thought syscon was more commonly used as abbr. of system-controller in the kernel code. > Arnd > > . > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/