Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754397AbbLJJat (ORCPT ); Thu, 10 Dec 2015 04:30:49 -0500 Received: from mail-wm0-f53.google.com ([74.125.82.53]:35908 "EHLO mail-wm0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751092AbbLJJaq (ORCPT ); Thu, 10 Dec 2015 04:30:46 -0500 Date: Thu, 10 Dec 2015 10:24:57 +0100 From: Peter Senna Tschudin To: "Geyslan G. Bem" Cc: Alan Stern , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/9v2] usb: host: ehci.h: remove space before function open parenthesis Message-ID: <20151210092457.GB4013@toshiba-peter.rsr.lip6.fr> References: <1449700359-14262-1-git-send-email-geyslan@gmail.com> <1449700359-14262-2-git-send-email-geyslan@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1449700359-14262-2-git-send-email-geyslan@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3995 Lines: 104 On Wed, Dec 09, 2015 at 07:32:31PM -0300, Geyslan G. Bem wrote: > Get rid of space between function name and open parenthesis. > > Caught by checkpatch: "WARNING: space prohibited between function name > and open parenthesis '('" > > Signed-off-by: Geyslan G. Bem > --- As with previous, missing the changelog here, but other than that the patch looks good to me. Acked-by: Peter Senna Tschudin > drivers/usb/host/ehci.h | 22 +++++++++++----------- > 1 file changed, 11 insertions(+), 11 deletions(-) > > diff --git a/drivers/usb/host/ehci.h b/drivers/usb/host/ehci.h > index 6a36ef4..46982df 100644 > --- a/drivers/usb/host/ehci.h > +++ b/drivers/usb/host/ehci.h > @@ -268,13 +268,13 @@ struct ehci_hcd { /* one per controller */ > }; > > /* convert between an HCD pointer and the corresponding EHCI_HCD */ > -static inline struct ehci_hcd *hcd_to_ehci (struct usb_hcd *hcd) > +static inline struct ehci_hcd *hcd_to_ehci(struct usb_hcd *hcd) > { > return (struct ehci_hcd *) (hcd->hcd_priv); > } > -static inline struct usb_hcd *ehci_to_hcd (struct ehci_hcd *ehci) > +static inline struct usb_hcd *ehci_to_hcd(struct ehci_hcd *ehci) > { > - return container_of ((void *) ehci, struct usb_hcd, hcd_priv); > + return container_of((void *) ehci, struct usb_hcd, hcd_priv); > } > > /*-------------------------------------------------------------------------*/ > @@ -327,9 +327,9 @@ struct ehci_qtd { > } __attribute__ ((aligned (32))); > > /* mask NakCnt+T in qh->hw_alt_next */ > -#define QTD_MASK(ehci) cpu_to_hc32 (ehci, ~0x1f) > +#define QTD_MASK(ehci) cpu_to_hc32(ehci, ~0x1f) > > -#define IS_SHORT_READ(token) (QTD_LENGTH (token) != 0 && QTD_PID (token) == 1) > +#define IS_SHORT_READ(token) (QTD_LENGTH(token) != 0 && QTD_PID(token) == 1) > > /*-------------------------------------------------------------------------*/ > > @@ -806,7 +806,7 @@ static inline void set_ohci_hcfs(struct ehci_hcd *ehci, int operational) > #define ehci_big_endian_desc(e) ((e)->big_endian_desc) > > /* cpu to ehci */ > -static inline __hc32 cpu_to_hc32 (const struct ehci_hcd *ehci, const u32 x) > +static inline __hc32 cpu_to_hc32(const struct ehci_hcd *ehci, const u32 x) > { > return ehci_big_endian_desc(ehci) > ? (__force __hc32)cpu_to_be32(x) > @@ -814,14 +814,14 @@ static inline __hc32 cpu_to_hc32 (const struct ehci_hcd *ehci, const u32 x) > } > > /* ehci to cpu */ > -static inline u32 hc32_to_cpu (const struct ehci_hcd *ehci, const __hc32 x) > +static inline u32 hc32_to_cpu(const struct ehci_hcd *ehci, const __hc32 x) > { > return ehci_big_endian_desc(ehci) > ? be32_to_cpu((__force __be32)x) > : le32_to_cpu((__force __le32)x); > } > > -static inline u32 hc32_to_cpup (const struct ehci_hcd *ehci, const __hc32 *x) > +static inline u32 hc32_to_cpup(const struct ehci_hcd *ehci, const __hc32 *x) > { > return ehci_big_endian_desc(ehci) > ? be32_to_cpup((__force __be32 *)x) > @@ -831,18 +831,18 @@ static inline u32 hc32_to_cpup (const struct ehci_hcd *ehci, const __hc32 *x) > #else > > /* cpu to ehci */ > -static inline __hc32 cpu_to_hc32 (const struct ehci_hcd *ehci, const u32 x) > +static inline __hc32 cpu_to_hc32(const struct ehci_hcd *ehci, const u32 x) > { > return cpu_to_le32(x); > } > > /* ehci to cpu */ > -static inline u32 hc32_to_cpu (const struct ehci_hcd *ehci, const __hc32 x) > +static inline u32 hc32_to_cpu(const struct ehci_hcd *ehci, const __hc32 x) > { > return le32_to_cpu(x); > } > > -static inline u32 hc32_to_cpup (const struct ehci_hcd *ehci, const __hc32 *x) > +static inline u32 hc32_to_cpup(const struct ehci_hcd *ehci, const __hc32 *x) > { > return le32_to_cpup(x); > } > -- > 2.6.3 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/