Date: Thu, 10 Dec 2015 10:58:15 +0100
From: Peter Senna Tschudin <peter.senna@gmail.com>
To: "Geyslan G. Bem" <geyslan@gmail.com>
Cc: Alan Stern <stern@rowland.harvard.edu>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/9v2] usb: host: ehci.h: fix single statement macros
Message-ID: <20151210095815.GD4013@toshiba-peter.rsr.lip6.fr>
References: <1449700359-14262-1-git-send-email-geyslan@gmail.com>
 <1449700359-14262-4-git-send-email-geyslan@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1449700359-14262-4-git-send-email-geyslan@gmail.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1286
Lines: 39

On Wed, Dec 09, 2015 at 07:32:33PM -0300, Geyslan G. Bem wrote:
> Don't use the 'do {} while (0)' wrapper in a single statement macro.
> 
> Caught by checkpatch: "WARNING: Single statement macros should not
> use a do {} while (0) loop"
> 
> Signed-off-by: Geyslan G. Bem <geyslan@gmail.com>
As with previous, missing the changelog, but other than that the patch
looks good to me.

Acked-by: Peter Senna Tschudin <peter.senna@gmail.com>
> ---
>  drivers/usb/host/ehci.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/host/ehci.h b/drivers/usb/host/ehci.h
> index cfeebd8..945000a 100644
> --- a/drivers/usb/host/ehci.h
> +++ b/drivers/usb/host/ehci.h
> @@ -244,9 +244,9 @@ struct ehci_hcd {			/* one per controller */
>  	/* irq statistics */
>  #ifdef EHCI_STATS
>  	struct ehci_stats	stats;
> -#	define COUNT(x) do { (x)++; } while (0)
> +#	define COUNT(x) ((x)++)
>  #else
> -#	define COUNT(x) do {} while (0)
> +#	define COUNT(x) ((void) 0)
>  #endif
>  
>  	/* debug files */
> -- 
> 2.6.3
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/