Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753602AbbLJKTF (ORCPT ); Thu, 10 Dec 2015 05:19:05 -0500 Received: from mail-wm0-f47.google.com ([74.125.82.47]:34847 "EHLO mail-wm0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753244AbbLJKTB (ORCPT ); Thu, 10 Dec 2015 05:19:01 -0500 Date: Thu, 10 Dec 2015 11:18:56 +0100 From: Peter Senna Tschudin To: "Geyslan G. Bem" Cc: Alan Stern , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 6/9v2] usb: host: ehci.h: use space after comma Message-ID: <20151210101856.GF4013@toshiba-peter.rsr.lip6.fr> References: <1449700359-14262-1-git-send-email-geyslan@gmail.com> <1449700359-14262-6-git-send-email-geyslan@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1449700359-14262-6-git-send-email-geyslan@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1738 Lines: 46 On Wed, Dec 09, 2015 at 07:32:35PM -0300, Geyslan G. Bem wrote: > Put space after comma. > > This patch also changes QH_NEXT macro for better reading. > > Caught by checkpatch: "ERROR: space required after that ','" > > Signed-off-by: Geyslan G. Bem > --- > drivers/usb/host/ehci.h | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/host/ehci.h b/drivers/usb/host/ehci.h > index 7b2b213..ea56147 100644 > --- a/drivers/usb/host/ehci.h > +++ b/drivers/usb/host/ehci.h > @@ -334,7 +334,7 @@ struct ehci_qtd { > /*-------------------------------------------------------------------------*/ > > /* type tag from {qh,itd,sitd,fstn}->hw_next */ > -#define Q_NEXT_TYPE(ehci,dma) ((dma) & cpu_to_hc32(ehci, 3 << 1)) > +#define Q_NEXT_TYPE(ehci, dma) ((dma) & cpu_to_hc32(ehci, 3 << 1)) > > /* > * Now the following defines are not converted using the > @@ -350,7 +350,8 @@ struct ehci_qtd { > #define Q_TYPE_FSTN (3 << 1) > > /* next async queue entry, or pointer to interrupt/periodic QH */ > -#define QH_NEXT(ehci,dma) (cpu_to_hc32(ehci, (((u32)dma)&~0x01f)|Q_TYPE_QH)) > +#define QH_NEXT(ehci, dma) \ > + (cpu_to_hc32(ehci, (((u32) dma) & ~0x01f) | Q_TYPE_QH)) For the maintainers: Is having two lines here better than having a line with 83 chars? > > /* for periodic/async schedules and qtd lists, mark end of list */ > #define EHCI_LIST_END(ehci) cpu_to_hc32(ehci, 1) /* "null pointer" to hw */ > -- > 2.6.3 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/