Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753750AbbLJKZS (ORCPT ); Thu, 10 Dec 2015 05:25:18 -0500 Received: from mail-vk0-f51.google.com ([209.85.213.51]:35697 "EHLO mail-vk0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751272AbbLJKZP (ORCPT ); Thu, 10 Dec 2015 05:25:15 -0500 MIME-Version: 1.0 In-Reply-To: <20151210100151.GE4013@toshiba-peter.rsr.lip6.fr> References: <1449700359-14262-1-git-send-email-geyslan@gmail.com> <1449700359-14262-5-git-send-email-geyslan@gmail.com> <20151210100151.GE4013@toshiba-peter.rsr.lip6.fr> Date: Thu, 10 Dec 2015 07:25:14 -0300 Message-ID: Subject: Re: [PATCH 5/9v2] usb: host: ehci.h: remove direct use of __attribute__ keyword From: "Geyslan G. Bem" To: Peter Senna Tschudin Cc: Alan Stern , Greg Kroah-Hartman , linux-usb@vger.kernel.org, LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3000 Lines: 85 2015-12-10 7:01 GMT-03:00 Peter Senna Tschudin : > On Wed, Dec 09, 2015 at 07:32:34PM -0300, Geyslan G. Bem wrote: >> Prefer to use __aligned(size) macro instead of >> __attribute__((aligned(size))). >> >> Caught by checkpatch: "WARNING" > Not sure about the WARNING here, maybe just remove this line? Or just to be changed to "Caught by checkpatch." > >> >> Signed-off-by: Geyslan G. Bem > As with previous, missing the changelog, but other than that the patch > looks good to me. > > Acked-by: Peter Senna Tschudin >> --- >> drivers/usb/host/ehci.h | 10 +++++----- >> 1 file changed, 5 insertions(+), 5 deletions(-) >> >> diff --git a/drivers/usb/host/ehci.h b/drivers/usb/host/ehci.h >> index 945000a..7b2b213 100644 >> --- a/drivers/usb/host/ehci.h >> +++ b/drivers/usb/host/ehci.h >> @@ -324,7 +324,7 @@ struct ehci_qtd { >> struct list_head qtd_list; /* sw qtd list */ >> struct urb *urb; /* qtd's urb */ >> size_t length; /* length of buffer */ >> -} __attribute__ ((aligned (32))); >> +} __aligned(32); >> >> /* mask NakCnt+T in qh->hw_alt_next */ >> #define QTD_MASK(ehci) cpu_to_hc32(ehci, ~0x1f) >> @@ -407,7 +407,7 @@ struct ehci_qh_hw { >> __hc32 hw_token; >> __hc32 hw_buf[5]; >> __hc32 hw_buf_hi[5]; >> -} __attribute__ ((aligned(32))); >> +} __aligned(32); >> >> struct ehci_qh { >> struct ehci_qh_hw *hw; /* Must come first */ >> @@ -535,7 +535,7 @@ struct ehci_itd { >> unsigned frame; /* where scheduled */ >> unsigned pg; >> unsigned index[8]; /* in urb->iso_frame_desc */ >> -} __attribute__ ((aligned (32))); >> +} __aligned(32); >> >> /*-------------------------------------------------------------------------*/ >> >> @@ -578,7 +578,7 @@ struct ehci_sitd { >> struct list_head sitd_list; /* list of stream's sitds */ >> unsigned frame; >> unsigned index; >> -} __attribute__ ((aligned (32))); >> +} __aligned(32); >> >> /*-------------------------------------------------------------------------*/ >> >> @@ -598,7 +598,7 @@ struct ehci_fstn { >> /* the rest is HCD-private */ >> dma_addr_t fstn_dma; >> union ehci_shadow fstn_next; /* ptr to periodic q entry */ >> -} __attribute__ ((aligned (32))); >> +} __aligned(32); >> >> /*-------------------------------------------------------------------------*/ >> >> -- >> 2.6.3 >> -- Regards, Geyslan G. Bem hackingbits.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/