Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751961AbbLJKuL (ORCPT ); Thu, 10 Dec 2015 05:50:11 -0500 Received: from mail-vk0-f47.google.com ([209.85.213.47]:35628 "EHLO mail-vk0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750902AbbLJKuJ (ORCPT ); Thu, 10 Dec 2015 05:50:09 -0500 MIME-Version: 1.0 In-Reply-To: <20151210104430.GE24965@localhost> References: <1449712366-31365-1-git-send-email-geyslan@gmail.com> <20151210104430.GE24965@localhost> Date: Thu, 10 Dec 2015 07:50:08 -0300 Message-ID: Subject: Re: [PATCH] usb: remove redundant conditions From: "Geyslan G. Bem" To: Johan Hovold Cc: Peter Senna Tschudin , Felipe Balbi , Greg Kroah-Hartman , Robert Baldyga , linux-usb@vger.kernel.org, LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1105 Lines: 36 2015-12-10 7:44 GMT-03:00 Johan Hovold : > On Wed, Dec 09, 2015 at 10:52:42PM -0300, Geyslan G. Bem wrote: >> This patch removes redundant conditions. >> >> - (!A || (A && B)) is the same as (!A || B). >> - (length && length > 5) can be reduced to a single evaluation. >> >> Caught by: cppcheck >> >> Signed-off-by: Geyslan G. Bem >> --- >> drivers/usb/gadget/udc/s3c-hsudc.c | 2 +- >> drivers/usb/host/fhci-sched.c | 2 +- >> drivers/usb/musb/musb_gadget.c | 5 ++--- >> drivers/usb/serial/io_edgeport.c | 35 ++++++++++++++--------------------- >> drivers/usb/serial/mos7840.c | 2 +- >> 5 files changed, 19 insertions(+), 27 deletions(-) > > Please split out (at least) the usb-serial changes into two patches. Ok, I'll send v2 later. > > Johan -- Regards, Geyslan G. Bem hackingbits.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/