Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752440AbbLJLzD (ORCPT ); Thu, 10 Dec 2015 06:55:03 -0500 Received: from mail-lf0-f42.google.com ([209.85.215.42]:32847 "EHLO mail-lf0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750952AbbLJLzA (ORCPT ); Thu, 10 Dec 2015 06:55:00 -0500 Subject: Re: [PATCH 4/9v2] usb: host: ehci.h: fix single statement macros To: "Geyslan G. Bem" , peter.senna@gmail.com References: <1449700359-14262-1-git-send-email-geyslan@gmail.com> <1449700359-14262-4-git-send-email-geyslan@gmail.com> Cc: Alan Stern , Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org From: Sergei Shtylyov Message-ID: <5669680E.4070304@cogentembedded.com> Date: Thu, 10 Dec 2015 14:54:54 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <1449700359-14262-4-git-send-email-geyslan@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1135 Lines: 39 Hello. On 12/10/2015 1:32 AM, Geyslan G. Bem wrote: > Don't use the 'do {} while (0)' wrapper in a single statement macro. > > Caught by checkpatch: "WARNING: Single statement macros should not > use a do {} while (0) loop" > > Signed-off-by: Geyslan G. Bem > --- > drivers/usb/host/ehci.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/host/ehci.h b/drivers/usb/host/ehci.h > index cfeebd8..945000a 100644 > --- a/drivers/usb/host/ehci.h > +++ b/drivers/usb/host/ehci.h > @@ -244,9 +244,9 @@ struct ehci_hcd { /* one per controller */ > /* irq statistics */ > #ifdef EHCI_STATS > struct ehci_stats stats; > -# define COUNT(x) do { (x)++; } while (0) > +# define COUNT(x) ((x)++) > #else > -# define COUNT(x) do {} while (0) > +# define COUNT(x) ((void) 0) Why not just empty #define? [...] MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/