Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753248AbbLJMUQ (ORCPT ); Thu, 10 Dec 2015 07:20:16 -0500 Received: from mail-vk0-f45.google.com ([209.85.213.45]:33548 "EHLO mail-vk0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752065AbbLJMUO (ORCPT ); Thu, 10 Dec 2015 07:20:14 -0500 MIME-Version: 1.0 In-Reply-To: <5669680E.4070304@cogentembedded.com> References: <1449700359-14262-1-git-send-email-geyslan@gmail.com> <1449700359-14262-4-git-send-email-geyslan@gmail.com> <5669680E.4070304@cogentembedded.com> Date: Thu, 10 Dec 2015 09:20:13 -0300 Message-ID: Subject: Re: [PATCH 4/9v2] usb: host: ehci.h: fix single statement macros From: "Geyslan G. Bem" To: Sergei Shtylyov Cc: Peter Senna Tschudin , Alan Stern , Greg Kroah-Hartman , linux-usb@vger.kernel.org, LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1397 Lines: 55 2015-12-10 8:54 GMT-03:00 Sergei Shtylyov : > Hello. > > On 12/10/2015 1:32 AM, Geyslan G. Bem wrote: > >> Don't use the 'do {} while (0)' wrapper in a single statement macro. >> >> Caught by checkpatch: "WARNING: Single statement macros should not >> use a do {} while (0) loop" >> >> Signed-off-by: Geyslan G. Bem >> --- >> drivers/usb/host/ehci.h | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/usb/host/ehci.h b/drivers/usb/host/ehci.h >> index cfeebd8..945000a 100644 >> --- a/drivers/usb/host/ehci.h >> +++ b/drivers/usb/host/ehci.h >> @@ -244,9 +244,9 @@ struct ehci_hcd { /* one per >> controller */ >> /* irq statistics */ >> #ifdef EHCI_STATS >> struct ehci_stats stats; >> -# define COUNT(x) do { (x)++; } while (0) >> +# define COUNT(x) ((x)++) >> #else >> -# define COUNT(x) do {} while (0) >> +# define COUNT(x) ((void) 0) > > > Why not just empty #define? Indeed. I'll change it. Tks Sergei. > > [...] > > MBR, Sergei > -- Regards, Geyslan G. Bem hackingbits.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/