Date: Thu, 10 Dec 2015 12:45:36 +0000
From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Xiubo Li <lixiubo@cmss.chinamobile.com>
CC: <broonie@kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] regmap: cache: Add warning info for the cache check
Message-ID: <20151210124535.GO6058@localhost.localdomain>
References: <1449715253-4517-1-git-send-email-lixiubo@cmss.chinamobile.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <1449715253-4517-1-git-send-email-lixiubo@cmss.chinamobile.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1293
Lines: 39

On Thu, Dec 10, 2015 at 10:40:53AM +0800, Xiubo Li wrote:
> If there is no cache used for the drivers, the register drfaults

s/drfaults/defaults/

> are not need any more. This patch will check this and print a
> warning.
> 
> Signed-off-by: Xiubo Li <lixiubo@cmss.chinamobile.com>
> ---
>  drivers/base/regmap/regcache.c | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/base/regmap/regcache.c b/drivers/base/regmap/regcache.c
> index 1c0210a..bdcd401 100644
> --- a/drivers/base/regmap/regcache.c
> +++ b/drivers/base/regmap/regcache.c
> @@ -100,15 +100,19 @@ int regcache_init(struct regmap *map, const struct regmap_config *config)
>  	int i;
>  	void *tmp_buf;
>  
> -	for (i = 0; i < config->num_reg_defaults; i++)
> -		if (config->reg_defaults[i].reg % map->reg_stride)
> -			return -EINVAL;
> -
>  	if (map->cache_type == REGCACHE_NONE) {
> +		if (config->num_reg_defaults)
> +			dev_warn(map->dev,
> +				 "No cache used with register defualts set!\n");

s/defualts/defaults/

Thanks,
Charles
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/