Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753061AbbLJOc4 (ORCPT ); Thu, 10 Dec 2015 09:32:56 -0500 Received: from mail-pf0-f196.google.com ([209.85.192.196]:32919 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751855AbbLJOcx (ORCPT ); Thu, 10 Dec 2015 09:32:53 -0500 X-Greylist: delayed 738 seconds by postgrey-1.27 at vger.kernel.org; Thu, 10 Dec 2015 09:32:53 EST Date: Thu, 10 Dec 2015 22:20:32 +0800 From: Minfei Huang To: Jessica Yu Cc: Rusty Russell , Josh Poimboeuf , Seth Jennings , Jiri Kosina , Vojtech Pavlik , Jonathan Corbet , Miroslav Benes , linux-api@vger.kernel.org, live-patching@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [RFC PATCH v2 4/6] livepatch: reuse module loader code to write relocations Message-ID: <20151210142032.GA2399@huangminfeis-MacBook-Pro.local> References: <1448943679-3412-1-git-send-email-jeyu@redhat.com> <1448943679-3412-5-git-send-email-jeyu@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1448943679-3412-5-git-send-email-jeyu@redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1193 Lines: 38 On 11/30/15 at 11:21P, Jessica Yu wrote: > + klp_for_each_reloc_sec(obj, reloc_sec) { > + relindex = reloc_sec->index; > + num_relas = pmod->sechdrs[relindex].sh_size / sizeof(Elf_Rela); > + rela = (Elf_Rela *) pmod->sechdrs[relindex].sh_addr; > + > + /* For each rela in this __klp_rela section */ > + for (i = 0; i < num_relas; i++, rela++) { > + sym = symtab + ELF_R_SYM(rela->r_info); > + symname = pmod->core_strtab + sym->st_name; > + > + if (sym->st_shndx == SHN_LIVEPATCH) { > + if (sym->st_info == 'K') > + ret = klp_find_external_symbol(pmod, symname, &addr); > + else > + ret = klp_find_object_symbol(obj->name, symname, &addr); > + if (ret) > + return ret; > + sym->st_value = addr; > + } > } > + ret = apply_relocate_add(pmod->sechdrs, pmod->core_strtab, > + pmod->index.sym, relindex, pmod); It is more appropiate to test the ret. Thanks Minfei > } > > - return 0; > + return ret; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/