Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754394AbbLJPIx (ORCPT ); Thu, 10 Dec 2015 10:08:53 -0500 Received: from down.free-electrons.com ([37.187.137.238]:34981 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753798AbbLJPIu convert rfc822-to-8bit (ORCPT ); Thu, 10 Dec 2015 10:08:50 -0500 From: Gregory CLEMENT To: Sascha Hauer Cc: "David S. Miller" , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Nicolas Ferre , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Thomas Petazzoni Subject: Re: [PATCH] net/macb: add support for resetting PHY using GPIO References: <1449683383-5022-1-git-send-email-gregory.clement@free-electrons.com> <20151210073756.GA11966@pengutronix.de> Date: Thu, 10 Dec 2015 16:08:08 +0100 In-Reply-To: <20151210073756.GA11966@pengutronix.de> (Sascha Hauer's message of "Thu, 10 Dec 2015 08:37:56 +0100") Message-ID: <871tau8hpj.fsf@free-electrons.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2446 Lines: 83 Hi Sascha, On jeu., déc. 10 2015, Sascha Hauer wrote: > Hi Gregory, > > On Wed, Dec 09, 2015 at 06:49:43PM +0100, Gregory CLEMENT wrote: >> With device tree it is no more possible to reset the PHY at board >> level. Furthermore, doing in the driver allow to power down the PHY when >> the network interface is no more used. >> >> The patch introduces a new optional property "phy-reset-gpio" inspired >> from the one use for the FEC. > > I don't think it's a good idea to further extend the usage of this > binding. The driver should use the phy-handle property and > of_phy_connect() which gives you a proper device node for the phy. Then > the phy device node should get the reset gpio. I know it's more work, So you suggest to pass from this binding: macb1: ethernet@fc028000 { phy-mode = "rmii"; status = "okay"; #address-cells = <1>; #size-cells = <0>; status = "okay"; phy-reset-gpio = <&pioE 6 GPIO_ACTIVE_HIGH>; ethernet-phy@1 { reg = <0x1>; interrupt-parent = <&pioB>; interrupts = <31 IRQ_TYPE_EDGE_FALLING>; }; }; to this binding macb1: ethernet@fc028000 { phy-mode = "rmii"; status = "okay"; #address-cells = <1>; #size-cells = <0>; status = "okay"; ethernet-phy@1 { reg = <0x1>; interrupt-parent = <&pioB>; interrupts = <31 IRQ_TYPE_EDGE_FALLING>; phy-reset-gpio = <&pioE 6 GPIO_ACTIVE_HIGH>; }; }; > but doing it like this gives you additional goodies like proper handling > of the max-speed property, a fixed-link if necessary and picking the Currently there is phy_connect_direct so we can already handle the preperty of the phy. > correct phy if there are muliple phys on the bus. but I agree with this one. Gregory > > Sascha > > -- > Pengutronix e.K. | | > Industrial Linux Solutions | http://www.pengutronix.de/ | > Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/