Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754682AbbLJPNu (ORCPT ); Thu, 10 Dec 2015 10:13:50 -0500 Received: from devils.ext.ti.com ([198.47.26.153]:57488 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754077AbbLJPNs (ORCPT ); Thu, 10 Dec 2015 10:13:48 -0500 From: Felipe Balbi To: "Geyslan G. Bem" , CC: "Geyslan G. Bem" , Greg Kroah-Hartman , Johan Hovold , Robert Baldyga , , Subject: Re: [PATCH] usb: remove redundant conditions In-Reply-To: <1449712366-31365-1-git-send-email-geyslan@gmail.com> References: <1449712366-31365-1-git-send-email-geyslan@gmail.com> User-Agent: Notmuch/0.21 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Thu, 10 Dec 2015 09:13:37 -0600 Message-ID: <87twnqjpzy.fsf@saruman.tx.rr.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1654 Lines: 48 --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable "Geyslan G. Bem" writes: > This patch removes redundant conditions. > > - (!A || (A && B)) is the same as (!A || B). > - (length && length > 5) can be reduced to a single evaluation. > > Caught by: cppcheck > > Signed-off-by: Geyslan G. Bem > --- I guess you didn't get previous comment in time; let's split this per driver so different maintainers can pick their parts. =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWaZajAAoJEIaOsuA1yqREsHkP/1Puya0qX45hgSqZRrxKLCU+ n1PeQkeia8gm82mkPsspL6ZKaSK2LTlVTUlIkidhxmyhPlzCSpZoW+K1TC8PdOcM 6M/1eYBoiWlPLCF6MgDIZ8hOTNdElUZeB+Go+HJOO6zgElAs0f4zTc+a8tKZRXKx OMOdRbptWvOMpHmCodUJUK5MFmaW4AUby4XVDU7yQxKcEH/wZB2DHnbDYvQJAZRE NXyYFm3YIR45bby55m+IEjpb7gyfzLGYb6R+NAwkMKLR8lWIU5r90Psz4wglnQCs 3q5lEsqP3MkOOKzVEL0FXQOT58AdDn+TYCMZyDrX2uQnn4TjyecZicmwCorIBp// RGXE6c1em3J70GfW5sKRAZgZDf8CiM7TASQs554vwP4evIpEIxl3rD1QeDWjD9tq l4H8COrDZvI+22Giyt/tQg8b6WN5sLbdAW9+4xJhiKkbXbNhveVMV75DjYPw7nM9 fhcSb5iiSUBmqVJu2KSUTsIGoy7TTRZtzqjT48gtKtkIQcNW0IQAwvPhyoPP7iRD DJqAgQ7/j8f1BKC2Ik0BNVKFoKS1qGxThg8RKPPNxId99MiMuLQzuiWjN9+28ojP ndrZyXdAOu4gCjujhFHPwspStuhmIdVReyYeKXkNYNPHLGLzrSp6fYNkGiJUF1+f wJWKXKyrNWFDQyjvgor0 =gO6G -----END PGP SIGNATURE----- --=-=-=-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/