Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754368AbbLJPQP (ORCPT ); Thu, 10 Dec 2015 10:16:15 -0500 Received: from mail-vk0-f52.google.com ([209.85.213.52]:35839 "EHLO mail-vk0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753908AbbLJPQN (ORCPT ); Thu, 10 Dec 2015 10:16:13 -0500 MIME-Version: 1.0 In-Reply-To: <87twnqjpzy.fsf@saruman.tx.rr.com> References: <1449712366-31365-1-git-send-email-geyslan@gmail.com> <87twnqjpzy.fsf@saruman.tx.rr.com> Date: Thu, 10 Dec 2015 12:16:12 -0300 Message-ID: Subject: Re: [PATCH] usb: remove redundant conditions From: "Geyslan G. Bem" To: Felipe Balbi Cc: Peter Senna Tschudin , Greg Kroah-Hartman , Johan Hovold , Robert Baldyga , linux-usb@vger.kernel.org, LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 811 Lines: 33 2015-12-10 12:13 GMT-03:00 Felipe Balbi : > "Geyslan G. Bem" writes: > >> This patch removes redundant conditions. >> >> - (!A || (A && B)) is the same as (!A || B). >> - (length && length > 5) can be reduced to a single evaluation. >> >> Caught by: cppcheck >> >> Signed-off-by: Geyslan G. Bem >> --- > > I guess you didn't get previous comment in time; let's split this per > driver so different maintainers can pick their parts. Okeydokey. :) > > -- > balbi -- Regards, Geyslan G. Bem hackingbits.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/