From: David Laight <David.Laight@ACULAB.COM>
To: "'Felipe Balbi'" <balbi@ti.com>, "Geyslan G. Bem" <geyslan@gmail.com>,
        "peter.senna@gmail.com" <peter.senna@gmail.com>
CC: "Geyslan G. Bem" <geyslan@gmail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Johan Hovold <johan@kernel.org>,
        Robert Baldyga <r.baldyga@samsung.com>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] usb: remove redundant conditions
Thread-Topic: [PATCH] usb: remove redundant conditions
Thread-Index: AQHRM11c84mZInHYN0e3/vTOpT/H7p7EVMDQ
Date: Thu, 10 Dec 2015 15:17:21 +0000
Message-ID: <063D6719AE5E284EB5DD2968C1650D6D1CBEA973@AcuExch.aculab.com>
References: <1449712366-31365-1-git-send-email-geyslan@gmail.com>
 <87twnqjpzy.fsf@saruman.tx.rr.com>
In-Reply-To: <87twnqjpzy.fsf@saruman.tx.rr.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
Content-Type: text/plain; charset="Windows-1252"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 820
Lines: 26

From: Felipe Balbi
> Sent: 10 December 2015 15:14
> "Geyslan G. Bem" <geyslan@gmail.com> writes:
> 
> > This patch removes redundant conditions.
> >
> >  - (!A || (A && B)) is the same as (!A || B).
> >  - (length && length > 5) can be reduced to a single evaluation.
> >
> > Caught by: cppcheck
> >
> > Signed-off-by: Geyslan G. Bem <geyslan@gmail.com>
> > ---
> 
> I guess you didn't get previous comment in time; let's split this per
> driver so different maintainers can pick their parts.

I also suspect that gcc will optimise out the redundant checks as well.

	David

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/