Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754726AbbLJPR6 (ORCPT ); Thu, 10 Dec 2015 10:17:58 -0500 Received: from mail-ob0-f170.google.com ([209.85.214.170]:36014 "EHLO mail-ob0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752974AbbLJPRz (ORCPT ); Thu, 10 Dec 2015 10:17:55 -0500 MIME-Version: 1.0 In-Reply-To: <20151129163346.GA13433@sophia> References: <20151129163346.GA13433@sophia> Date: Thu, 10 Dec 2015 16:17:55 +0100 Message-ID: Subject: Re: [PATCH v2] gpio: Add GPIO support for the ACCES 104-IDI-48 From: Linus Walleij To: William Breathitt Gray Cc: Alexandre Courbot , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1537 Lines: 35 On Sun, Nov 29, 2015 at 5:33 PM, William Breathitt Gray wrote: > The ACCES 104-IDI-48 family of PC/104 utility boards feature 48 > individually optically isolated digital inputs. Enabled inputs feature > change-of-state detection capability; if change-of-state detection is > enabled, an interrupt is fired off if a change of input level > (low-to-high or high-to-low) is detected. Change-of-state IRQs are > enabled/disabled on 8-bit boundaries, for a total of six boundaries. > > This driver provides GPIO and IRQ support for these 48 channels of > digital input. The base port address for the device may be configured > via the idi_48_base module parameter. The interrupt line number for the > device may be configured via the idi_48_irq module parameter. > > Signed-off-by: William Breathitt Gray > --- > Changes in v2: > - Reimplement irq_ack callback as a NOOP since status register read in > idi_48_irq_handler clears all pending interrupts. Sorry I seem to have already applied an earlier version of the driver to my tree. Can you make an incremental patch fixing up what is on my "devel" branch to what was in v2 instead? https://git.kernel.org/cgit/linux/kernel/git/linusw/linux-gpio.git/log/?h=devel Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/