Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754821AbbLJP07 (ORCPT ); Thu, 10 Dec 2015 10:26:59 -0500 Received: from mail-ob0-f175.google.com ([209.85.214.175]:36328 "EHLO mail-ob0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754756AbbLJP05 (ORCPT ); Thu, 10 Dec 2015 10:26:57 -0500 MIME-Version: 1.0 X-Originating-IP: [217.173.44.24] In-Reply-To: <7380785.3TF39KbbER@wuerfel> References: <7380785.3TF39KbbER@wuerfel> Date: Thu, 10 Dec 2015 16:26:56 +0100 Message-ID: Subject: Re: [PATCH] overlayfs: include linux/pagemap.h for PAGE_CACHE_SIZE From: Miklos Szeredi To: Arnd Bergmann Cc: "linux-unionfs@vger.kernel.org" , Kernel Mailing List , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1490 Lines: 44 On Thu, Dec 10, 2015 at 4:10 PM, Arnd Bergmann wrote: > The overlayfs has started enforcing a maximum file size, but is missing > the header file that defines the PAGE_CACHE_SIZE constant in some > configurations. Hmm, it uses MAX_LFS_FILESIZE. MAX_LFS_FILESIZE is defined in , which doesn't include . includes however. So shouldn't MAX_LFS_FILESIZE be defined in instead? Thanks, Miklos > > fs/overlayfs/super.c: In function 'ovl_fill_super': > fs/overlayfs/super.c:939:29: error: 'PAGE_CACHE_SIZE' undeclared (first use in this function) > > Signed-off-by: Arnd Bergmann > Fixes: 7b1746cac878 ("ovl: setattr: check permissions before copy-up") > Cc: > --- > The patch that introduced this was marked for stable, so I'm marking this > the same way. > > diff --git a/fs/overlayfs/super.c b/fs/overlayfs/super.c > index ea94e50a3473..a4cbdf9824c7 100644 > --- a/fs/overlayfs/super.c > +++ b/fs/overlayfs/super.c > @@ -9,6 +9,7 @@ > > #include > #include > +#include > #include > #include > #include > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/